Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: true with Node adapter #6661

Closed
1 task done
millette opened this issue Mar 26, 2023 · 2 comments · Fixed by #6928
Closed
1 task done

host: true with Node adapter #6661

millette opened this issue Mar 26, 2023 · 2 comments · Fixed by #6928
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: ssr Related to SSR (scope)

Comments

@millette
Copy link
Contributor

What version of astro are you using?

2.1.7

Are you using an SSR adapter? If so, which one?

node

What package manager are you using?

pnpm

What operating system are you using?

linux

What browser are you using?

firefox

Describe the Bug

Using the following configuration:

{
  server: {
    host: true // "0.0.0.0",
  },
  integrations: [tailwind()],
  output: 'server',
  adapter: node({
    mode: 'standalone',
  }),
}

Instead of listening on all addresses, it says "http://undefined:3000" with "astro preview".

Link to Minimal Reproducible Example

https://codesandbox.io/p/sandbox/thirsty-ride-r3726r?on=codesandbox&file=%2Fpackage.json&selection=%5B%7B%22endColumn%22%3A1%2C%22endLineNumber%22%3A15%2C%22startColumn%22%3A1%2C%22startLineNumber%22%3A15%7D%5D

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp added the - P3: minor bug An edge case that only affects very specific usage (priority) label Mar 27, 2023
@matthewp matthewp changed the title server host = true bug host: true with Node adapter Mar 27, 2023
@JerryWu1234
Copy link
Contributor

JerryWu1234 commented Apr 10, 2023

@matthewp withastro/roadmap#493
could you push forward with this discussion if you feel free.
This discussion is the same as well as this bug.

@natemoo-re
Copy link
Member

Cleaned up the PR @JerryWu1234 started in #6928! We'll try to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: ssr Related to SSR (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants