404 page doesn't render in production mode

[xriter]

What version of astro are you using?

2.10.7

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Safari

Describe the Bug

In SSR mode, when going to a page that doesn't exist, the 404 page should be rendered (the default or custom one). It does this correctly in dev mode, but in production mode it only renders a blank page.

Using @astrojs/node 5.3.3 with node v18.16.1

Also see the repro.
Run npm run build && npm run preview and go to /doesntexist.

What's the expected result?

The 404 page should be rendered correctly in SSR production mode.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-trfvka?file=src%2Fpages%2Findex.astro

Participation

• I am willing to submit a pull request for this issue.

[natemoo-re]

Guessing that this will be closed by #8070 which fixes a few edge cases introduced in #7754

[lilnasy]

@xriter Could not reproduce the issue.

Works the same in dev and build on stackblitz.

[xriter]

@lilnasy I made a little 🎞️ screen recording showing how to reproduce in Stackblitz.
Check out the video: https://github.com/withastro/astro/assets/70454441/6c1b6748-99b0-4b80-9c41-39e055ed95d1

(Besides that I also experience this problem in real world projects of course).

[lilnasy]

Is there a difference when you run node dist/server/entry.mjs instead of npm run preview?

[xriter]

@lilnasy I just tried. When running node dist/server/entry.mjs the 404 page DOES render indeed. 🤔
So what's the difference? I guess it also still should be working correctly when running npm run preview? (At least it did so before...)

Although, I run a website in production in a Docker container, (that is using node dist/server/entry.mjs), and there it does not work... Wondering if it has something to do with the domain or dns (localhost vs 127.0.0.1)...

[xriter]

@lilnasy Not fully convinced about the workaround tag. See my updated previous comment. 🙈

[lilnasy]

Although, I run a website in production in a Docker container, (that is using node dist/server/entry.mjs), and there it does not work...

If the 404 page was prerendered, it may have been an issue introduced recently.

[xriter]

If the 404 page was prerendered, it may have been an issue introduced recently.

It uses the custom 404.astro, and no prerender variable was set. I believe it then always does SSR right?

[lilnasy]

It should, unless the output config is "hybrid".

[xriter]

It should, unless the output config is "hybrid".

The config is set as

output: "server",
adapter: node({
    mode: "standalone",
}),

From the docs (https://docs.astro.build/en/guides/server-side-rendering/#enabling-ssr-in-your-project) I understand that in that case you don't set const prerender = true.

[lilnasy]

Yeah, prerendering-related issues are probably not the culprit then. However, it might need another reproduction to investigate that issue.

[xriter]

@lilnasy I do think the Important tag should be reapplied, since the assumed workaround doesn't actually work in the production environment (Docker).

[lilnasy]

the assumed workaround doesn't actually work in the production environment (Docker).

Could you share the dockerfile so I can try to confirm?

[xriter]

Dockerfile

FROM node:18-slim
WORKDIR /app
COPY ./package.json ./
RUN npm install --production=false --verbose
COPY . .
RUN npm run build --verbose

RUN addgroup --system --gid 1001 nodejs
RUN adduser --system --uid 1001 astro

USER astro
ENV HOST=0.0.0.0
ENV PORT 8001
EXPOSE 8001
CMD node ./dist/server/entry.mjs

docker-compose.yml

version: "3.7"

services:
    node:
        build:
            context: .
            args:
                NODE_ENV: production
        working_dir: /app
        env_file:
            - .env
        environment:
            - NODE_ENV=production
        ports:
            - "8001:8001"
        restart: unless-stopped

[lilnasy]

Couldn't reproduce it with docker either.

Temporary link to running project with docker run --rm -it -p 8001:8001 7b80

[xriter]

Very interesting. I don't understand. I use those configurations. On a VPS, using reverse proxies; which keeps me looking in the area of something with dns resolving?

It worked fine before. After 'some' update (don't know which version number) it just stopped. I get it to repro with npm run preview on stackblitz. You agree there's 'something' not how it's supposed to be, right?

[lilnasy]

Yes, I could reproduce the issue when running npm run preview.

[xriter]

After having downgraded version by version, everything works fine up until 2.9.6. From 2.9.7 the problem starts occurring.

// Latest working version
"@astrojs/node": "5.3.0",
"astro": "2.9.6"

[xriter]

Unfortunately the updates of Astro 2.10.10 haven't solved this problem.