refactor(preact): Drop preact-ssr-prepass in favor of renderToStringAsync
#11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a72bee8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: preact
|
CI failure doesn't look to be related, unless I'm misunderstanding the error? |
|
That's unrelated, it's a flaky test |
bluwy
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #9733, alternative solution to #9733 (comment)
preact-ssr-prepassto instead utilizerenderToStringAsyncfrompreact-render-to-string, which has surpassed it as the recommended tool, see chore: Update readme for suspense rendering preactjs/preact-render-to-string#338Testing
Existing tests should cover. Different implementation, but same intended result.
Docs
Users shouldn't need to know the method of rendering changed.
Additional Context
~6.3.1, but rtsAsync is only available in6.4.0and newer. I couldn't replicate the linked bug in newer versions so I imagine we fixed it at some point.preact-ssr-prepasswas our recommended solution but we have dropped references to it since. It certainly still works, but isn't what we'd recommend and issues might go somewhat unnoticed unfortunately -- small team, too many repos to juggle as it is.