From 3e3046874a34e510f1ecfb80e073939b379542b1 Mon Sep 17 00:00:00 2001 From: Princesseuh Date: Tue, 19 Jul 2022 11:06:12 -0400 Subject: [PATCH 1/3] Add missing media attribute on MetaHTMLAttributes --- packages/astro/astro-jsx.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index cf76e6e58e89..68ad185475c0 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -820,6 +820,7 @@ declare namespace astroHTML.JSX { content?: string | URL | undefined | null; 'http-equiv'?: string | undefined | null; name?: string | undefined | null; + media: string | undefined | null; } interface MeterHTMLAttributes extends HTMLAttributes { From acec6e4bb84646b8304122102c1df4245cb5a883 Mon Sep 17 00:00:00 2001 From: Princesseuh Date: Tue, 19 Jul 2022 11:20:41 -0400 Subject: [PATCH 2/3] Fixed media not being optional, oops --- packages/astro/astro-jsx.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 68ad185475c0..2f01aafe4773 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -820,7 +820,7 @@ declare namespace astroHTML.JSX { content?: string | URL | undefined | null; 'http-equiv'?: string | undefined | null; name?: string | undefined | null; - media: string | undefined | null; + media?: string | undefined | null; } interface MeterHTMLAttributes extends HTMLAttributes { From a7e244ab9f619db24f12d1a0d1613caf01adda87 Mon Sep 17 00:00:00 2001 From: Princesseuh Date: Tue, 19 Jul 2022 11:41:14 -0400 Subject: [PATCH 3/3] Add changeset --- .changeset/old-walls-draw.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/old-walls-draw.md diff --git a/.changeset/old-walls-draw.md b/.changeset/old-walls-draw.md new file mode 100644 index 000000000000..cda5405b3362 --- /dev/null +++ b/.changeset/old-walls-draw.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Added missing `media` attributes from the JSX definitions for the `meta` element