Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ViewTransition script from being added by mistake #8268

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes ViewTransitions from astro/components.
  • This was added very early (before the first release I think), but we now say to import from astro:transitions.
  • Having this as part of astro/components brings its script if you are just using, for example, <Code />.

Testing

  • Added a test to the Code component test

Docs

Bug fix.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 96b08bd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Aug 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 6de3476

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s not a way to export this from astro/components and have a script? I guess not as easily, but I do like having our components be in one spot.

@matthewp
Copy link
Contributor Author

@natemoo-re Not right now, that's what experimental.optimizeHoistedScript aims to solve, but it has some issues right now.

@natemoo-re
Copy link
Member

Gotcha. Okay this works for me, then!

@matthewp matthewp merged commit 3b0d805 into 2-legacy Aug 29, 2023
@matthewp matthewp deleted the fix-vt-components branch August 29, 2023 17:08
@astrobot-houston astrobot-houston mentioned this pull request Aug 29, 2023
matthewp added a commit that referenced this pull request Aug 29, 2023
* Prevent ViewTransition script from being added by mistake

* Add the 2-legacy branch to CI
matthewp added a commit that referenced this pull request Aug 29, 2023
)

* Prevent ViewTransition script from being added by mistake

* Add the 2-legacy branch to CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants