Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text - Loses upload status if post is closed/reopened during the upload #1504

Closed
pinarol opened this issue Oct 28, 2019 · 1 comment
Assignees
Labels
Media [Type] Bug Something isn't working

Comments

@pinarol
Copy link
Contributor

pinarol commented Oct 28, 2019

Detected during testing #1503.
Also reproducible @ 9f4afd6 develop
Tested with iPhone 8 plus, iOS 13.1

Reality:

  • Add media & text block, tap placeholder and choose Choose from device
  • Start upload but before it finishes close the post by selecting Update Post
  • Re-open the post
  • Upload progress is shown properly, but an empty white background is displayed under the progress view.
  • Tap close(x), select Update Post
  • Wait until upload is finished
  • Re-open the post and see that media placeholder is shown back again

mediaTextUpload

Expected:

  • Add media & text block, tap placeholder and choose Choose from device
  • Start upload but before it finishes close the post by selecting Update Post
  • Re-open the post
  • Upload progress is shown properly
  • A dimmed & low resolution copy of the uploaded image should be shown
  • Wait until upload is finished
  • Re-open the post
  • We should see that the image is shown properly
@pinarol pinarol added [Type] Bug Something isn't working Media labels Oct 28, 2019
@pinarol
Copy link
Contributor Author

pinarol commented Oct 28, 2019

I also came across with this validation error with the scenario:

  • Add media & text block, tap placeholder and choose Choose from device
  • Start upload but before it finishes close the post by selecting Update Post
  • Wait until the upload finishes
  • Re-open the post and you'll see:

Screen Shot 2019-10-28 at 15 24 52

mediaTextUpload2

@pinarol pinarol changed the title Media & Text - Loses upload status if post closed/reopened during the upload Media & Text - Loses upload status if post is closed/reopened during the upload Oct 28, 2019
@pinarol pinarol self-assigned this Oct 31, 2019
@pinarol pinarol closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant