CCQ/Node/EVM: Backfill cache #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
from
40778e5 to
1d083e9
Compare
bruce-riley
force-pushed
the
ccq/node/evm_refactor
branch
from
698d3cf to
6d9204f
Compare
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
3 times, most recently
from
6859413 to
30a5c80
Compare
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
panoel
reviewed
Nov 29, 2023
panoel
reviewed
Nov 29, 2023
panoel
reviewed
Nov 29, 2023
panoel
reviewed
Nov 29, 2023
panoel
reviewed
Nov 29, 2023
panoel
reviewed
Nov 29, 2023
panoel
previously approved these changes
Nov 29, 2023
panoel
previously approved these changes
Nov 29, 2023
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
4 times, most recently
from
1289501 to
39d21ae
Compare
|
Should add a feature flag to enable this. Initially it can default to disabled, so we can ask a single guardian to enable it. Once it is working smoothly we would probably want to make it default to enabled. |
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
3 times, most recently
from
3de3465 to
4896d52
Compare
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
2 times, most recently
from
7cdf463 to
81e08ab
Compare
bruce-riley
changed the base branch from
main
to
node/evm_batch_poller_refactor
bruce-riley
changed the base branch from
node/evm_batch_poller_refactor
to
main
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
from
81e08ab to
9d20f4e
Compare
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
from
9d20f4e to
c79f803
Compare
bruce-riley
force-pushed
the
ccq/node/evm_backfill_cache
branch
from
c79f803 to
cb0f99a
Compare
|
There is a guardian flag to make back filling configurable. It defaults to true. This is okay because if the back fill fails, it does not kill the watcher, it just disables back filling and continues. |
bingyuyap
reviewed
Mar 15, 2024
bingyuyap
reviewed
Mar 15, 2024
bingyuyap
reviewed
Mar 15, 2024
bingyuyap
reviewed
Mar 15, 2024
bingyuyap
previously approved these changes
Mar 15, 2024
evan-gray
approved these changes
Mar 15, 2024
panoel
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.