Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: upgrade grpc to v1.57.1 #3797

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

bingyuyap
Copy link
Contributor

@bingyuyap bingyuyap commented Feb 20, 2024

  • tested with tilt up
  • ci tests passes
  • also read patch notes to check if upgrading other packages could lead to other unintended effects

@bruce-riley @evan-gray wondering if there are any more tests to do to make sure a safe upgrade

@bingyuyap bingyuyap marked this pull request as ready for review February 20, 2024 20:53
@bruce-riley bruce-riley requested a review from SEJeff February 21, 2024 14:01
Copy link
Contributor

@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would suggest that @SEJeff review as well. Also probably want to push out as a pre-release to testnet first.

@evan-gray evan-gray merged commit 5f52aa8 into main Mar 8, 2024
22 checks passed
@evan-gray evan-gray deleted the bing/grpc-dependabot-upgrade branch March 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants