-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node/P2P: Add default bootstrap peers #3852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fec9de
to
869aa12
Compare
evan-gray
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me. relatively small amount of code for less config needed across the ecosystem.
869aa12
to
5d9e701
Compare
bingyuyap
previously approved these changes
Mar 22, 2024
barnjamin
reviewed
Mar 22, 2024
panoel
reviewed
Mar 22, 2024
5d9e701
to
4e084b4
Compare
panoel
previously approved these changes
Mar 22, 2024
a23ff60
to
5539331
Compare
evan-gray
approved these changes
Mar 22, 2024
SEJeff
approved these changes
Mar 22, 2024
bingyuyap
reviewed
Mar 22, 2024
panoel
approved these changes
Mar 22, 2024
bingyuyap
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hard codes the bootstrap peers and network ID for the guardian, spy and query proxy server, based on the environment (mainnet or testnet). It allows them to be overridden using the existing parameters, but that should be discouraged.
For devnet / tilt, the existing parameters should still be used because the bootstrap peer may not be deterministic.
The following config parameters should be removed for guardiand and the query proxy server:
The following config changes should be made for the spy:
mainnet
ortestnet
.Scenarios Tested
--env mainnet
--env testnet
--env
but network parameters (allowed)--env
and network parameters (not allowed)--env mainnet
--env testnet