Ethereum: Move relayer #3866
Merged
Ethereum: Move relayer #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
eth_move_relayer
branch
from
0975fd6 to
2b97d5b
Compare
bruce-riley
commented
Apr 1, 2024
bruce-riley
force-pushed
the
eth_move_relayer
branch
2 times, most recently
from
5111ff9 to
4cdbbb9
Compare
evan-gray
reviewed
Apr 2, 2024
evan-gray
reviewed
Apr 2, 2024
evan-gray
force-pushed
the
eth_move_relayer
branch
4 times, most recently
from
ff2e971 to
38d62b7
Compare
evan-gray
requested review from
a5-pickle,
kev1n-peters,
barnjamin,
nonergodic,
gator-boi and
kcsongor
as code owners
bruce-riley
force-pushed
the
eth_move_relayer
branch
3 times, most recently
from
dbccf92 to
8fc4fe4
Compare
evan-gray
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Confirmed the diffs of the copied files are sane
diff ethereum/.gitignore relayer/ethereum/.gitignore
diff ethereum/Makefile relayer/ethereum/Makefile
diff ethereum/contracts/interfaces/IWormhole.sol relayer/ethereum/contracts/interfaces/IWormhole.sol
diff ethereum/contracts/libraries/external/BytesLib.sol relayer/ethereum/contracts/libraries/external/BytesLib.sol
diff ethereum/foundry.toml relayer/ethereum/foundry.toml
diff ethereum/package-lock.json relayer/ethereum/package-lock.json
diff ethereum/package.json relayer/ethereum/package.json
gator-boi
reviewed
Apr 8, 2024
|
I think the new relayer directory could use a readme with instructions for building and testing :) |
|
@gator-boi I added a basic readme file. More details would need to be provided by whoever owns the relayer contracts. |
bruce-riley
force-pushed
the
eth_move_relayer
branch
from
d15a6e4 to
0563bdb
Compare
gator-boi
approved these changes
Apr 8, 2024
evan-gray
approved these changes
Apr 8, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the relayer contracts out of the
ethereumfolder intorelayer/ethereum.This change is necessary as part of the migration from deploying the core and token bridge contracts with truffle to using forge, which is necessary because truffle is deprecated.
The original plan for this PR was to change the relayer to use the
wormhole-solidity-sdkfor theIWormholeinterface so that it is not directly dependent on the old folder. However, this changed the byte code for the contracts, which changed the devnet deploy address for the proxy contract (because it is deployed withcreate2), breaking various tests. The decision was made to "kick that can down the road" and not make the move to use the sdk. InsteadIWormholehas been copied into the relayer folder. The same goes for theBytesLiblibrary, which was also copied into the relayer folder.