-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch from ganache to anvil #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d378f2f
to
81164db
Compare
d15a6e4
to
0563bdb
Compare
0165f22
to
57557bb
Compare
bruce-riley
approved these changes
Apr 12, 2024
panoel
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only inspected the files I am code owner on.
barnjamin
reviewed
Apr 12, 2024
barnjamin
approved these changes
Apr 12, 2024
kcsongor
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 👍
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the devnet / ci EVM node from
ganache
toanvil
. Notably, this had a couple impacts:anvil
is set to automine at 1s withblock-time=1
somine.js
is no longer neededanvil
simulates 2 epoch finality (includingsafe
andfinalized
tags), so waiting forfinalized
blocks is now required as needed. This is done withawait ethProvider.send("anvil_mine", ["0x40"]);
While touching the CI tests for
sdk/js
,sdk/js-query
, andaccountant
, I also took the opportunity toJsonRpcProvider
to avoid worrying about calling.destroy()
secp256k1
andbigint
log messagestestTimeout
in the jest config instead of usingjest.setTimeout
everywherejest.config.json
filenamerollback detected in timestamp cache
inunsafeDevMode
as it gets triggered thousands of times whenanvil_mine
is used--guardiand_loglevel=info
from the workflow as it's no longer needed for debugging the noted issueBonus: All that cleanup means the Tilt CI logs are now ~8300 lines instead of > 10,000