node: generalised governance

[kcsongor]

The EVM implementation handles governance requests of the form:

current_set_index: 4
# generic evm call
messages: {
  sequence: 4513077582118919631
  nonce: 2809988562
  evm_call: {
    chain_id: 3
    governance_contract: "0xD8E4C2DbDd2e2bd8F1336EA691dBFF6952B1a6eB"
    target_contract: "0xF890982f9310df57d00f659cf4fd87e65adEd8d7"
    abi_encoded_call: "BEEFFACE"
  }
}

The solana implementation handles governance requests of the form:

current_set_index: 4
# generic solana call
messages: {
  sequence: 4513077582118919631
  nonce: 2809988562
  solana_call: {
    chain_id: 3
    governance_contract: "3u8hJUVTA4jH1wYAyUur7FFZVQ8H635K3tSHHF4ssjQ5"
    encoded_instruction: "BEEFFACE"
  }
}

The expectation is for the abi_encoded_call and encoded_instruction calls to be generated (and verified) via external tools.

[bruce-riley]

This looks really good! But I think you also have to make a change to node/cmd/guardiand/admintemplate.go.

[evan-gray]

Approved but had a couple questions.

[evan-gray]

Approving pending clarification.

[evan-gray]

agree with reworking checks in Serialize to return errors in a future PR #3897

[djb15]

Why are we not using parseAddress in these templates?

[kcsongor]

because parseAddress attempts to parse any 32 byte address-like thing into a (left-padded) 32 byte address

wormhole/node/cmd/guardiand/admintemplate.go

Lines 1061 to 1084 in 51d34bf

	func parseAddress(s string) (string, error) {
	// try base58
	b, err := base58.Decode(s)
	if err == nil {
	return leftPadAddress(b)
	}
	// try bech32
	_, b, err = bech32.Decode(s)
	if err == nil {
	return leftPadAddress(b)
	}
	// try hex
	if len(s) > 2 && strings.ToLower(s[:2]) == "0x" {
	s = s[2:]
	}
	a, err := hex.DecodeString(s)
	if err != nil {
	return "", fmt.Errorf("invalid hex address: %v", err)
	}
	return leftPadAddress(a)
	}

in this case, we only care about EVM addresses, so we can be a bit more specific

[djb15]

Can we add a check in here to enforce that chain id doesn't exceed max uint16?