node: moves ccqP2pMessagesSent counter to happy path
#3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
approved these changes
May 3, 2024
panoel
approved these changes
May 3, 2024
|
@panoel @bruce-riley thanks for approving the PR, would you please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor adjustment (and potential fix) by relocating the
ccqP2pMessagesSentcounter to only increment during successful publish events. Previously, this counter tallied both successful and unsuccessful attempts, which quite contradicted its label and description that specifically refer to "sent" messages. Now, the counter will only increment on the successful execution path.