Node/Devnet: Extract first guardian name from bootstrap peers #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
approved these changes
May 6, 2024
barnjamin
approved these changes
May 6, 2024
evan-gray
deleted the
node/devnet_extract_first_guardian_from_bootstrap_peers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guardian in Tilt currently expects the first guardian name as listed in the bootstrap peers to be "guardian-0.guardian" so for the other guardians, waits until this host is visible before finishing initialization. In load testing, we have to use a different format host name. This PR extracts the host name from the first entry in the bootstrap peers.
Note that PR only effects devnet, not testnet or mainnet.