Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node,sdk: Mantle mainnet #3959

Merged
merged 2 commits into from
May 31, 2024

Conversation

evan-gray
Copy link
Contributor

@evan-gray evan-gray commented May 28, 2024

This PR makes the required changes to support Mantle in mainnet.

It also fixes a CI breakage due to a change in the devnet relayer address. I was unable to pin down the exact cause, but I did take the opportunity to pin the foundry version to a docker image in addition to updating the addresses.

panoel
panoel previously approved these changes May 28, 2024
Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding some more manual tokens that have significant ($200k+ 24h volume)?: https://www.coingecko.com/en/categories/mantle-ecosystem

I would add MNT, METH, JOE & Mantled bridged WETH, USDC and USDT as a minimum

@evan-gray
Copy link
Contributor Author

Probably worth adding some more manual tokens that have significant ($200k+ 24h volume)?: https://www.coingecko.com/en/categories/mantle-ecosystem

I would add MNT, METH, JOE & Mantled bridged WETH, USDC and USDT as a minimum

I thought that's what #3958 was for 😬

djb15
djb15 previously approved these changes May 28, 2024
Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3958 to add to list of manual tokens

kcsongor
kcsongor previously approved these changes May 28, 2024
SEJeff
SEJeff previously approved these changes May 28, 2024
@evan-gray evan-gray dismissed stale reviews from panoel, djb15, kcsongor, and SEJeff via 0a6a3f3 May 30, 2024 18:43
@evan-gray evan-gray marked this pull request as draft May 30, 2024 21:17
@evan-gray evan-gray marked this pull request as ready for review May 30, 2024 22:56
@evan-gray evan-gray requested a review from nonergodic as a code owner May 30, 2024 22:56
@evan-gray evan-gray requested review from panoel, djb15, kcsongor and SEJeff May 30, 2024 22:56
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ethereum and testing directories

@evan-gray evan-gray merged commit 4f20d17 into wormhole-foundation:main May 31, 2024
24 checks passed
@evan-gray evan-gray deleted the mantle-mainnet branch May 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants