Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Don't hang on post to Loki #4267

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Node: Don't hang on post to Loki #4267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion node/pkg/telemetry/loki.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/grafana/loki/pkg/logproto"
lokiflag "github.com/grafana/loki/pkg/util/flagext"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"
"github.com/prometheus/common/config"
"github.com/prometheus/common/model"
)
Expand All @@ -39,6 +40,20 @@ type ExternalLoggerLoki struct {
localLogger *zap.Logger
}

var (
lokiMessagesSent = promauto.NewCounter(
prometheus.CounterOpts{
Name: "wormhole_loki_messages_sent",
Help: "Total number of log messages posted to Loki",
})

lokiMessagesDropped = promauto.NewCounter(
prometheus.CounterOpts{
Name: "wormhole_loki_messages_dropped",
Help: "Total number of log messages dropped while posting to Loki",
})
)

func (logger *ExternalLoggerLoki) log(time time.Time, message json.RawMessage, level zapcore.Level) {
lokiLabels := logger.labels[level]

Expand All @@ -56,7 +71,12 @@ func (logger *ExternalLoggerLoki) log(time time.Time, message json.RawMessage, l
Labels: lokiLabels,
}

logger.c.Chan() <- entry
select {
case logger.c.Chan() <- entry:
lokiMessagesSent.Inc()
default:
lokiMessagesDropped.Inc()
}

// A fatal error exits, which can cause us to lose messages. Flush everything.
if level == zapcore.FatalLevel {
Expand Down
Loading