sdk: Add functions for type-safe conversions from integers to ChainID #4271
+109
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places in the Guardian, the following is done:
As
ChainID()
is just a custom type arounduint16
, this is equivalent to doing an unchecked type-conversion to uint16, which could result in edge-case truncation/overflow/sign-change issues.The motivation for this change is to provide a clear way to go from any integer type for a ChainID in a type-safe way. With this PR, someone could instead write the following:
If the general idea seems good, I will merge this work with #4239 in the future so that the function introduced in that PR will use
KnownChainIDFromNumber
in the numeric string context.