Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

TimePicker opens twice on edit time when it's placed inside ListView close to WebView #4305

Open
zs-dima opened this issue Nov 5, 2018 · 15 comments
Labels
a/webview e/4 🕓 4 help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested m/high impact ⬛ p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@zs-dima
Copy link

zs-dima commented Nov 5, 2018

Description

TimePicker opens twice on edit time when it's placed inside ListView close to WebView

Steps to Reproduce

  1. Make xaml layout like:
<ListView ItemsSource="{Binding SomeSource}">
    <ListView.ItemTemplate>
        <DataTemplate>
            <ViewCell>
                <Grid RowSpacing="0" ColumnSpacing="0">
                    <Grid.ColumnDefinitions>
                        <ColumnDefinition Width = "30*"/>
                        <ColumnDefinition Width = "100"/>
                    </Grid.ColumnDefinitions>
                    <WebView Grid.Column="0" Margin="0" IsEnabled="False">
                        <WebView.Source>
                            <HtmlWebViewSource Html="&lt;html>&lt;body>&lt;p>Some HTML text&lt;/p>&lt;/body>&lt;/html>" />
                        </WebView.Source>
                    </WebView>
                    <TimePicker Grid.Column="1" />
                </Grid>
            </ViewCell>
        </DataTemplate>
    </ListView.ItemTemplate>
</ListView>
  1. Assign SomeSource to the some non-empty list.
  2. Run app and tap TimePicker to select time.
  3. Confirm time selection.
  4. Time selection will appear again by itself for some reason!

Expected Behavior

Time selection had not appear twice
It have to appear once as if TimePicker used without ListView.

Actual Behavior

Time selection appear twice by itself for some reason.

Basic Information

  • Version with issue: 3.3
  • Last known good version: -
  • IDE: Visual Studio 2017
  • Platform Target Frameworks:
    • Android: 8.1
@LarsNymand
Copy link

One of my users experience the same - also inside a ListView. (I cannot reproduce it myself)

@zs-dima
Copy link
Author

zs-dima commented Nov 6, 2018

I cannot reproduce it myself

You could easily reproduce it following steps from above

@CayasSoftware
Copy link

I have a reproducing sample that show it is not only connected to the webview but to all views that are in the list. https://github.com/CayasSoftware/xam-picker

@zs-dima
Copy link
Author

zs-dima commented Nov 7, 2018

https://github.com/CayasSoftware/xam-picker

Thanks for the sample, hope this XF issue will be fixed

@rmarinho
Copy link
Member

rmarinho commented Nov 7, 2018

Yap able to reproduce seems to happen with not just webview but other controsl like @CayasSoftware exemple shows.

Thanks

@nagarjun075
Copy link

I am also facing the same kind of issue. But in my scenario I have 2 TimePickers in my ViewCell and if I open the second TimePicker then the second TimePicker opened twice and the first TimePicker also opened automatically in the end.

Thanks

@mmichelbb
Copy link

mmichelbb commented Nov 20, 2018

I seem to be having the same issue. Actually I have two timepickers in a listview cell and after entering the second timepicker's value, the popup fires again with the value in it and after dismissing that one, the first timepicker fires a popup with it's value in it.

Also provided a project demonstrating the issue:
TimePickerListTest.zip

@Danielv3
Copy link

Danielv3 commented Dec 4, 2018

Same issue here... :(

@WilliamWatterson86
Copy link

WilliamWatterson86 commented Dec 7, 2018

I have this issue too. I have 2 timepickers on a form and when i change the second one, the first one is popped up again. This has only started to happen in v3.3+ - v3.2 worked ok.

@mmichelbb @Danielv3 - were you able to work around your issue in the meantime?

@SabinaSc
Copy link

SabinaSc commented Dec 7, 2018

Same issue me too... two timepickers and one DatePicker inside a ListView.Header: when I touch one of them they all open sequently.

@WilliamWatterson86
Copy link

In my case it doesn’t seem to be related to a list. I am using RgPopups plugin and if there have been two pop ups shown before I select an time on my last timepicker I get the issue. iOS is ok

@khoduley
Copy link

Same to me. Xamarin.Forms 3.1 is good.

<controls:BorderlessDatePicker x:Name="datePicker" Grid.Row="6" Grid.Column="2" Grid.ColumnSpan="3" Style="{StaticResource pickerStyle}" Format="dd MMM yyyy" Date="{Binding BirthDate}" MaximumDate="{Binding MaxBirthDate}">
controls:BorderlessDatePicker.Behaviors
<behaviors:UnfocusedToCommandBehavior UnfocusedCommand="{Binding BirthDateCommand}" />
</controls:BorderlessDatePicker.Behaviors>
</controls:BorderlessDatePicker>

<BoxView.Behaviors>
<behaviors:FocusingTapGestureBehavior FocusingView="{x:Reference datePicker}" />
</BoxView.Behaviors>

@SR84
Copy link
Contributor

SR84 commented Dec 13, 2018

The same here. Version 3.2 ist working fine.

@CayasSoftware
Copy link

CayasSoftware commented Jan 8, 2019

I tested the current Service Release 3.4.0.100999 with my sample app and can say that it fixes the picker reappearance. I assume that the fix to: #4187 also fixed this issue here.

@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Jul 7, 2019
@Enigma205
Copy link

I have the same issue but with ItemTemplate in a ListView, The View is visited twice when entering the page containing the ListView.
XF 4.5.prev 4

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Feb 24, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Sep 18, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/webview e/4 🕓 4 help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested m/high impact ⬛ p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Development

No branches or pull requests