Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File path completion with dash in path #3173

Closed
12 tasks done
achalddave opened this issue Oct 6, 2018 · 1 comment · Fixed by #3174
Closed
12 tasks done

File path completion with dash in path #3173

achalddave opened this issue Oct 6, 2018 · 1 comment · Fixed by #3174

Comments

@achalddave
Copy link

achalddave commented Oct 6, 2018

Issue Prelude

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your issue:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have read and understood YCM's README, especially the
    Frequently Asked Questions section.
  • I have searched YCM's issue tracker to find issues similar to the one I'm
    about to report and couldn't find an answer to my problem. (Example Google
    search.
    )
  • If filing a bug report, I have included the output of vim --version.
  • If filing a bug report, I have included the output of :YcmDebugInfo.
  • If filing a bug report, I have attached the contents of the logfiles using
    the :YcmToggleLogs command.
  • If filing a bug report, I have included which OS (including specific OS
    version) I am using.
  • If filing a bug report, I have included a minimal test case that reproduces
    my issue, including what I expected to happen and what actually happened.
  • If filing a installation failure report, I have included the entire output
    of install.py (or cmake/make/ninja) including its invocation
  • I understand this is an open-source project staffed by volunteers and
    that any help I receive is a selfless, heartfelt gift of their free time. I
    know I am not entitled to anything and will be polite and courteous.
  • I understand my issue may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Thank you for adhering to this process! It ensures your issue is resolved
quickly and that neither your nor our time is needlessly wasted.

Issue Details

Issue #281 pointed out that filename completion in "#include" statements breaks when the file path includes a dash. The issue was closed by ycm-core/ycmd@a12a0a3, but I'm still seeing an issue with dashes in file paths more generally. Is this supposed to be the case? Or are there some settings that can help me fix this?

ycm-dash-filepath

  • What did you expect to happen?
    File path completion menu would be available after "-" is inserted.

Diagnostic data

Output of vim --version

NVIM v0.3.0
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/bin/cc -Wconversion -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/home/achald/scratch/neovim/build/config -I/home/achald/scratch/neovim/src -I/home/achald/scratch/neovim/.deps/usr/include -I/usr/include -I/home/achald/scratch/neovim/build/src/nvim/auto -I/home/achald/scratch/neovim/build/include
Compiled by [email protected]

Features: +acl +iconv +jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/home/achald/local/neovim-v0.3.0/share/nvim"

Run :checkhealth for more info```

## Output of `YcmDebugInfo`

> Place the output here, or a link to a [gist][].

Printing YouCompleteMe debug information...
-- Client logfile: /tmp/ycm_wu5_vx73.log
-- Server Python interpreter: /home/achald/local/anaconda3/envs/py/bin/python
-- Server Python version: 3.6.5
-- Server has Clang support compiled in: False
-- Clang version: None
-- No extra configuration file found
-- Server running at: http://127.0.0.1:41218
-- Server process ID: 137814
-- Server logfiles:
--   /tmp/ycmd_41218_stdout_vi_0tafz.log
--   /tmp/ycmd_41218_stderr_54fdyprj.log

Contents of YCM, ycmd and completion engine logfiles

Add let g:ycm_log_level = 'debug' to vimrc, restart Vim, reproduce the
issue, and include link here to a gist containing the entire logfiles for
ycm, ycmd and any completer logfiles listed by :YcmToggleLogs.

Repeated:

2018-10-06 15:10:12,530 - INFO - Received ready request
2018-10-06 15:10:12,626 - INFO - Received event notification
2018-10-06 15:10:12,626 - ERROR - No semantic completer exists for filetypes: ['sh']
Traceback (most recent call last):
  File "/home/achald/dotfiles/vim/.vim/plugged/YouCompleteMe/third_party/ycmd/ycmd/../ycmd/server_state.py", line 101, in FiletypeCompletionAvailable
    self.GetFiletypeCompleter( filetypes )
  File "/home/achald/dotfiles/vim/.vim/plugged/YouCompleteMe/third_party/ycmd/ycmd/../ycmd/server_state.py", line 90, in GetFiletypeCompleter
    current_filetypes ) )
ValueError: No semantic completer exists for filetypes: ['sh']

OS version, distribution, etc.

CentOS 7

Output of build/install commands

Probably not relevant?

@micbou
Copy link
Collaborator

micbou commented Oct 6, 2018

This should be fixed by PR ycm-core/ycmd#1104.

zzbot added a commit that referenced this issue Nov 18, 2018
[READY] Update ycmd

Include the following changes:

 - PR ycm-core/ycmd#1080: replace Boost canonical function with our own implementation;
 - PR ycm-core/ycmd#1104: improve filename completer;
 - PR ycm-core/ycmd#1121: support completion FixIts for C-family languages;
 - PR ycm-core/ycmd#1122: update jdt.ls to 0.26.0;
 - PR ycm-core/ycmd#1123: install fixed version of TypeScript in third-party folder;
 - PR ycm-core/ycmd#1124: only add the necessary directories to Python path.

Fixes #3173.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3174)
<!-- Reviewable:end -->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants