Auto merge of #1104 - micbou:filepath-completer-improvements, r=bstal…

…etic

[READY] Improve filename completer

This PR brings the following improvements to the filename completer:
 - allow completion of paths containing spaces;
 - allow completion of multiple paths on the same line;
 - allow completion of relative paths not starting with `.`, `..`, or `./`;
 - allow completion of Windows environment variables (e.g. `%USERPROFILE%`).

The first three improvements are achieved by assuming that if a user types `[something]/` and `[something]/` is an existing path (absolute or relative to the working directory) then he want to complete that path.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1104)
<!-- Reviewable:end -->

ycmd/completers/cpp/flags.py

@@ -27,8 +27,14 @@
 import inspect
 from future.utils import PY2, native
 from ycmd import extra_conf_store
-from ycmd.utils import ( re, ToCppStringCompatible, OnMac, OnWindows, ToUnicode,
-                         ToBytes, PathsToAllParentFolders )
+from ycmd.utils import ( ListDirectory,
+                         OnMac,
+                         OnWindows,
+                         PathsToAllParentFolders,
+                         re,
+                         ToCppStringCompatible,
+                         ToBytes,
+                         ToUnicode )
 from ycmd.responses import NoExtraConfDetected
 
 # -include-pch and --sysroot= must be listed before -include and --sysroot
@@ -515,26 +521,12 @@ def _SelectMacToolchain():
   ]
 
   for toolchain in MAC_CLANG_TOOLCHAIN_DIRS:
-    if _MacClangIncludeDirExists( toolchain ):
+    if os.path.exists( toolchain ):
       return toolchain
 
   return None
 
 
-# Ultimately, this method exists only for testability
-def _GetMacClangVersionList( candidates_dir ):
-  try:
-    return os.listdir( candidates_dir )
-  except OSError:
-    # Path might not exist, so just ignore
-    return []
-
-
-# Ultimately, this method exists only for testability
-def _MacClangIncludeDirExists( candidate_include ):
-  return os.path.exists( candidate_include )
-
-
 # Return the list of flags including any Clang headers found in the supplied
 # toolchain. These are required for the same reasons as described below, but
 # unfortunately, these are in versioned directories and there is no easy way to
@@ -547,11 +539,11 @@ def _LatestMacClangIncludes( toolchain ):
   # extract this information from xcode-select, though xcode-select -p does not
   # point at the toolchain directly.
   candidates_dir = os.path.join( toolchain, 'usr', 'lib', 'clang' )
-  versions = _GetMacClangVersionList( candidates_dir )
+  versions = ListDirectory( candidates_dir )
 
   for version in reversed( sorted( versions ) ):
     candidate_include = os.path.join( candidates_dir, version, 'include' )
-    if _MacClangIncludeDirExists( candidate_include ):
+    if os.path.exists( candidate_include ):
       return [ '-isystem', candidate_include ]
 
   return []

ycmd/completers/cpp/include_cache.py

@@ -33,9 +33,8 @@
 from ycmd import responses
 from ycmd.completers.general.filename_completer import ( GetPathType,
                                                          GetPathTypeName )
+from ycmd.utils import GetModificationTime, ListDirectory
 
-import logging
-_logger = logging.getLogger( __name__ )
 
 """ Represents single include completion candidate.
 name is the name/string of the completion candidate,
@@ -95,7 +94,7 @@ def GetIncludes( self, path, is_framework = False ):
 
   def _AddToCache( self, path, includes, mtime = None ):
     if not mtime:
-      mtime = _GetModificationTime( path )
+      mtime = GetModificationTime( path )
     # mtime of 0 is "a magic value" to represent inaccessible directory mtime.
     if mtime:
       with self._cache_lock:
@@ -107,7 +106,7 @@ def _GetCached( self, path, is_framework ):
     with self._cache_lock:
       cache_entry = self._cache.get( path )
     if cache_entry:
-      mtime = _GetModificationTime( path )
+      mtime = GetModificationTime( path )
       if mtime > cache_entry[ 'mtime' ]:
         includes = self._ListIncludes( path, is_framework )
         self._AddToCache( path, includes, mtime )
@@ -118,14 +117,8 @@ def _GetCached( self, path, is_framework ):
 
 
   def _ListIncludes( self, path, is_framework ):
-    try:
-      names = os.listdir( path )
-    except OSError:
-      _logger.exception( 'Can not list entries for include path %s.', path )
-      return []
-
     includes = []
-    for name in names:
+    for name in ListDirectory( path ):
       if is_framework:
         if not name.endswith( '.framework' ):
           continue
@@ -136,12 +129,3 @@ def _ListIncludes( self, path, is_framework ):
       includes.append( IncludeEntry( name, entry_type ) )
 
     return includes
-
-
-def _GetModificationTime( path ):
-  try:
-    return os.path.getmtime( path )
-  except OSError:
-    _logger.exception( 'Can not get modification time for include path %s.',
-                       path )
-    return 0