Update jdt.ls to 0.26.0, Java 11 supported. #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Thanks for the PR.
Assuming 0.26.0 didn't break any tests, 
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale)
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 89 89
Lines 7004 7004
=======================================
Hits 6835 6835
Misses 169 169 |
micbou
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 LGTMs obtained (and 1 stale)
|
@zzbot r+ |
|
📌 Commit cf3c4a4 has been approved by |
zzbot
added a commit
that referenced
this pull request
Oct 8, 2018
Update jdt.ls to 0.26.0, Java 11 supported. when jdt.ls version < 0.26.0 : Java 11 not supported: Could not determine java version from '11'. java.lang.IllegalArgumentException: Could not determine java version from '11'. ...... <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1122) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
|
Thanks for the PR |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Nov 18, 2018
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1080: replace Boost canonical function with our own implementation; - PR ycm-core/ycmd#1104: improve filename completer; - PR ycm-core/ycmd#1121: support completion FixIts for C-family languages; - PR ycm-core/ycmd#1122: update jdt.ls to 0.26.0; - PR ycm-core/ycmd#1123: install fixed version of TypeScript in third-party folder; - PR ycm-core/ycmd#1124: only add the necessary directories to Python path. Fixes #3173. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3174) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when jdt.ls version < 0.26.0 :
Java 11 not supported:
Could not determine java version from '11'.
java.lang.IllegalArgumentException: Could not determine java version from '11'.
......
This change is