Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the prop be hidden is the only one, a blank prop line would show up. #14

Closed
1 task done
Gitbreast opened this issue Feb 23, 2023 · 5 comments · May be fixed by #18
Closed
1 task done

If the prop be hidden is the only one, a blank prop line would show up. #14

Gitbreast opened this issue Feb 23, 2023 · 5 comments · May be fixed by #18

Comments

@Gitbreast
Copy link

Gitbreast commented Feb 23, 2023

Info:

  • OS: macOS

  • Logseq ver: 0.8.17

  • Plugin ver: 1.5.3

  • Theme name: null

  • ⚠ Do i have issue with DISABLED my custom.css?

Description:
If the prop be hidden is the only one, a blank prop line would show up.

To Reproduce:
Hide a prop, and type the prop name to a block or page, make sure it's the only one.

Expected behavior:
No blank line.

Screenshots
image
In this case I hide tooo and toc.
Editing:
image
End editing:
image

Attach files
Add (via drag-n-drop) .zip with .md files (if it needs) to help with bugfixind

@yoyurec
Copy link
Owner

yoyurec commented Feb 23, 2023

yes ) it was always
as i'm not editing the core code of Logseq and working "on top of it", there are some limitations ((
no possibility to show Logseq "native placeholder", not good idea to hide it at all, cose you will have no clickable zone...
image

for now...

@Gitbreast
Copy link
Author

Gitbreast commented Feb 23, 2023

@yoyurec Sorry for I'm not sure if I understood. I understood the clickable zone part. Is it possible to separate it in to 2 cases? If it's not a pure property block (like my screenshots) then hide it, or it's a pure property block then show a line as a clickable zone?

@Gitbreast
Copy link
Author

Btw in this case, I'm trying to use the toc:: no property to stop some blocks show in the toc generator plugin and trying to hide it XD

@yoyurec
Copy link
Owner

yoyurec commented Feb 23, 2023

Logseq has props blocks. They have a background color...
When you hide props via custom names Logseq config.edn OR using system predefined such as icon:: and there is no other visible items in the list - Logseq shows "Properties" text (as on my screen) and not 'backgrounded-props-block',
I can't do the same (at least for now).

Plugin hides props lines via CSS/JS, not Logseq system! So Logseq continues to think that there is/are prop(s) and shows it as styled block (((

not looking to who (Logseq/plugin) and how (placeholder text "Properties" / props block) doing this - you NEED to have something to click on to edit!

so i will not hide 'all-items-hidden-but-still-visible-props-colored-block' due UX

even if i mimic Logseq behavior - you will see same "noise" in your content - something like this
image

so a possible solution for you - hide blocks via custom.css, killing UX in honor of UI )))

@Gitbreast
Copy link
Author

@yoyurec Thank you for the explanation now I understood, wish Logseq would have a better solution for this XDXD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants