Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal crtl-r binding passthrough #14492

Closed
1 task done
giulianopz opened this issue Jul 15, 2024 · 3 comments
Closed
1 task done

terminal crtl-r binding passthrough #14492

giulianopz opened this issue Jul 15, 2024 · 3 comments
Labels
duplicate Additional reports of an existing issue

Comments

@giulianopz
Copy link

giulianopz commented Jul 15, 2024

Check for existing issues

  • Completed

Describe the feature

At the moment, if I open the integrated terminal and I press crtl-r, the menu for recents projects opens up (since I remapped the Workspace::projects::OpenRecent command to this keys) but I would like the terminal to process this keyboard input to reverse-search recent commands with bash.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@giulianopz giulianopz changed the title give priority to terminal over IDE when processinf key bindings give priority to terminal over IDE when processing key bindings Jul 15, 2024
@notpeter
Copy link
Member

@notpeter notpeter added duplicate Additional reports of an existing issue and removed feature [core label] triage labels Jul 15, 2024
@notpeter notpeter changed the title give priority to terminal over IDE when processing key bindings terminal crtl-r binding passthrough Jul 15, 2024
@giulianopz
Copy link
Author

Hi @giulianopz please see here:

* [Shortcut for reverse history search in terminal triggers symbol view instead #14033 (comment)](https://github.com/zed-industries/zed/issues/14033#issuecomment-2226764353)

hi @notpeter, thanks but that's weird IMHO: if so, I must explicitly list in the keymap.json all the keystrokes I want to forward to the terminal. This should be the default behaviour when the terminal it's focused (w/o any configurations). What do you think?

@notpeter
Copy link
Member

notpeter commented Jul 15, 2024

Apologies, for the brevity. Yes, I think this is an issue. For the moment I wanted to direct you to a workaround which will allow you to have the terminal operate as you expect.

This is definitely unsolved, especially if users want to be able to use the full range of ctrl- prefixed keyboard shortcuts while in terminal that doesn't leave anything for Zed. On the other hand we want to support people's usage models. On MacOS we leverage the cmd key , but (for the moment) we have not create default bindings for Linux/Windows using the super / windows key as an alternate modifier.

Some people want ctrl-w to close their terminal.
Some people want ctrl-w to delete the previous word.
Somebody's going to be unhappy with the default.

So we are aware and working towards trying strike the right balance. Please bear with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Additional reports of an existing issue
Projects
None yet
Development

No branches or pull requests

2 participants