Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed silent fail with use of ~ homedir shortcut #196

Closed
wants to merge 1 commit into from

Conversation

poltak
Copy link

@poltak poltak commented Aug 6, 2016

  • adds in new package expand-home-dir (this may not be welcome)
  • simply traverses the servers.pem string and expands ~ into the full homedir path, if present, via function exposed by package
  • previously path.resolve() could not handle the ~ shortcut and would cause the SSH connection to (silently) fail in the deploy and setup commands
  • works with both servers.pem strings containing ~ and absolute paths
  • fixes Using "~" in pem is making mup silently fail #189

- adds in new package `expand-home-dir`
- simply traverses the `servers.pem` string and expands `~` into the full homedir path, if present
- previously `path.resolve` could not handle the `~` shortcut and would cause the deploy and setup commands to fail
- fixes zodern#189
@madushan1000
Copy link
Contributor

Hi @poltak,
Thank you for the pr.
Could you refactor this into more general solution so that any path used in the config file has homedir expansion?

@avishaan
Copy link

@madushan1000 although I agree this is a problem with other directories, it makes sense that you go and merge this one at least. This is literally the problem raised in #291, #286, #135, #87, #245, #42, #222, #179 with the oldest one being 9 months old

@zodern zodern closed this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using "~" in pem is making mup silently fail
4 participants