Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better label for variable: Existing zowe runtime directory #4209

Open
wants to merge 1 commit into
base: v3.x/staging
Choose a base branch
from

Conversation

pavelzlatnik
Copy link
Contributor

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes #4073

Changes proposed in this PR

Better variable label, so it is less confusing for customer (in description is written it is mountpoint to TARGET library, it is allocated as TARGET library via PSWI or SMP/E job, but variable is originally named runtime directory). It serve as a "runtime" just for install launcher).
image

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

Signed-off-by: Pavel Zlatnik <[email protected]>
Copy link

github-actions bot commented Feb 26, 2025

build 7087 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13540306100

Copy link

github-actions bot commented Feb 26, 2025

Test workflow 6183 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4209/zowe-3.2.0-pr-4209-7087-20250226091833.pax
Running on machine: zzow11
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13540489733

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Zowe runtime directory is where almost everything EXCEPT the launcher resides.

The launcher resides in datasets, not unix, and is not involved in the installation process.

The documentation and YAML refer to this as the "Zowe Runtime" currently, so I do not understand needing a change in the workflow.

Can you explain what problem you are solving?

@pavelzlatnik
Copy link
Contributor Author

The Zowe runtime directory is where almost everything EXCEPT the launcher resides.

The launcher resides in datasets, not unix, and is not involved in the installation process.

The documentation and YAML refer to this as the "Zowe Runtime" currently, so I do not understand needing a change in the workflow.

Can you explain what problem you are solving?

Hi,
Based of my understanding and what zowe guys told to me, they referred as "Launcher" to zwe, and calling zwe command (zwe install, zwe init, etc.)
And it is exactly what is done under this mounted directory, from this directory is launched zowe installer, which creates RUNTIME datasets (referred as launcher to me, if there is another thing which is referred as Launcher as well, there is already even more confusion).

Biggest issue for me is that this zowe directory is labeled as "zowe runtime" from the project beginning, but is mounted on TARGET dataset created within SMP/E via this JCL.

//* - Change ${thlq} to the high level qualifier of the target

Which lead in past to confusion between TARGET and RUNTIME datasets, and has another issues hidden (I had already experience with product, which was technically similar to how zowe operates and how is installed/configured. There were separated groups which makes products SMP/E installations, and groups which makes product configurations in product runtime. Person who wanted to "launch" the installer has no permission to change file permissions (like umask 0002;
chmod -R 775) to TARGET dataset based on policy set for production systems, they should always do modification on RUNTIME datasets only, ie. RUNTIME datasets which has been copy of TARGET datasets.) I just wanted to distinguish the label, so installing person has at least some hint that this is not RUNTIME datasets with all its consequences.

@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Feb 28, 2025

Zowe's launcher is a program here https://github.com/zowe/launcher which resides in SZWEAUTH dataset as member ZWELNCH. The ZFS directories are unrelated to it. It calls "zwe" at runtime, but "zwe" has many other uses that are not at runtime, such as install time and configuration.
The "zowe runtime" is called that in the primary configuration file

runtimeDirectory: ""

And throughout the documentation ( https://docs.zowe.org/search?q=zowe%20runtime%20directory )

The runtime directory is not the runtime datasets, in that one is in unix and the other is not, but the thing they both have in common is that they comprise the "runtime", that is, the read-only code that can be used by 1-or-more configurations of zowe "instances".
These concepts and names exist with or without SMPE, with or without z/OSMF workflows, as there is a variety of ways to install and configure Zowe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

PSWI: Existing Zowe runtime directory not pre-populated
3 participants