Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Fix the size of return value by eth_getStorageAt #744

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Sep 21, 2022

Description

This PR makes eth_getStorageAt return 32 bytes data for any set storage.
For example, eth_getStorageAt in current Edge returns 4 bytes data for the storage where 2 uint16 values are stored. But other EVM chain always returns 32 bytes (at least as far as I checked in Goerli Ethereum Test Net and Mumbai Polygon PoS Test Net)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 added the bug fix Functionality that fixes a bug label Sep 21, 2022
@Kourin1996 Kourin1996 self-assigned this Sep 21, 2022
@Kourin1996 Kourin1996 changed the title Fix the return of eth_getStorageAt Fix the size of return value from eth_getStorageAt Sep 21, 2022
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the fix 🙏

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #744 (6e22ed2) into develop (7ada10f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #744      +/-   ##
===========================================
- Coverage    52.48%   52.48%   -0.01%     
===========================================
  Files          130      130              
  Lines        17069    17068       -1     
===========================================
- Hits          8959     8958       -1     
  Misses        7466     7466              
  Partials       644      644              
Impacted Files Coverage Δ
jsonrpc/eth_endpoint.go 71.45% <100.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kourin1996 Kourin1996 changed the title Fix the size of return value from eth_getStorageAt Fix the size of return value by eth_getStorageAt Sep 21, 2022
@zivkovicmilos
Copy link
Contributor

@Kourin1996

You are clear to merge this 🚀

@Kourin1996 Kourin1996 merged commit ec907d3 into develop Oct 3, 2022
@Kourin1996 Kourin1996 deleted the hotfix/fix-zero-value-of-eth_getStorageAt branch October 3, 2022 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants