Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-absolute cairoPath #307

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Handle non-absolute cairoPath #307

merged 9 commits into from
Feb 8, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Feb 6, 2023

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC February 6, 2023 13:56
@FabijanC FabijanC merged commit c47402c into master Feb 8, 2023
@FabijanC FabijanC deleted the cairo-path branch February 8, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle cairoPaths for non-absolute paths
2 participants