-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to starknet 0.11.0 #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathan-SL
commented
Mar 15, 2023
FabijanC
requested changes
Mar 16, 2023
- Cairo1 compilation on docker mode [wip]
- Update branch
- Remove cairoPath from cairo1 compilation - Add cairo1 checker function
- Add properties on devnet response - Update response type
FabijanC
requested changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we supporting cairo1 compilation through custom compiler (without docker)? If so, shouldn't this be tested? And if we want to test this, we need to add compiler installation to our CI/CD workflow.
- Call script with source
FabijanC
requested changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
contract_address
on transaction object fromstarknet.getTransaction(txHash)
changed tosender_address
devnet.createBlock()
no longer returns Block but an object withclass_hash
devnet.sendMessageToL2()
expects new argumentpaidFeeOnL1
to be passeddevnet.setTime()
anddevnet.increaseTime()
are updated.Usage related changes
npx hardhat starknet-compile-cairo1
to compile cairo1 contractsDevelopment related changes
docker-vmlang-rust-test
npx hardhat starknet-compile
skips cairo1 contractsChecklist:
test
directory (with a test case consisting ofnetwork.json
,hardhat.config.ts
,check.ts
)plugin
branch ofstarknet-hardhat-example
:Adapt to cairo-lang 0.11.0 starknet-hardhat-example#104test.sh
to use my example repo branchtest.sh
to to use the original branch (after the example repo PR has been merged)