utils.ts: dont match parameters in constructor name check #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a function name is contained in any part of the constructor parameter name, it is incorrectly selected as the constructor, eg:
there is then an ABI map entry with key
owner
that ends up getting matched to theowner
substring offirst_owner
, which causes it to get selected as the constructorAbi in theStarknetContractFactory
constructor if it is encountered before the real constructor.this replaces the
includes()
check with a regexp that should only match function names.