Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPCS ruleset. #53

Merged
merged 2 commits into from
May 13, 2022
Merged

Add PHPCS ruleset. #53

merged 2 commits into from
May 13, 2022

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented May 13, 2022

Description of the Change

Adds a .phpcs.xml.dist file to the root directory to allow IDEs to automatically pick up the coding standards.

Updates gitignore to ignore any local overrides a developer may set up.

The config file uses the WordPress standard as that is what is listed in the GitHub action.

steps:
- uses: actions/checkout@v2
- name: WPCS check
uses: 10up/wpcs-action@stable
with:
standard: 'WordPress'

Closes #50

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@peterwilsoncc peterwilsoncc requested review from a team and iamdharmesh and removed request for a team May 13, 2022 05:01
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, Thanks for adding this @peterwilsoncc.

@peterwilsoncc peterwilsoncc merged commit 5d55714 into develop May 13, 2022
@peterwilsoncc peterwilsoncc deleted the add/phpcs-config-file branch May 13, 2022 05:59
@jeffpaul jeffpaul added this to the 1.1.0 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add phpcs config file to project.
3 participants