Update/asset loading #281
Draft
Update/asset loading #281
+26
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiankaegy, the tests are failing for now, as we've not released the update in the framework, but what do you think of this approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR moves the asset loading trait out of each theme and plugin and into the WP Framework. The only real change, is that we need to pass some vars in to set up the paths, so that the framework knows where to asset files.
This is reliant on 10up/wp-framework#5 being merged and released.
How to test the Change
Ensure JS and CSS files are loading correctly.
Changelog Entry
Credits
Props @darylldoyle
Checklist: