Add runtime output for micromaterial #143

m-frey · 2024-12-10T12:32:53Z

Description and Context

This pull request introduces runtime output functionality for the micro-discretization in the MAT_Struct_Multiscale material model. The new RUNTIMEOUTPUT_GP flag allows controlled runtime output with the following options:

none: No runtime output.
all: Outputs runtime data for all Gauss points of elements using this material.
gp1: Outputs runtime data for the first Gauss point of elements using this material only.

Currently, only displacements are output. Additional outputs, including stress and strain, will be introduced in a subsequent merge request.

isteinbrecher

@m-frey thanks for the contribution, I left some comments.

src/core/io/src/4C_io_discretization_visualization_writer_mesh.hpp

src/mat/4C_mat_micromaterial.hpp

src/stru_multi/4C_stru_multi_microstatic.hpp

src/stru_multi/4C_stru_multi_microstatic.cpp

tests/input_files/sohex8_multiscale_macro.dat

src/inpar/4C_inpar_validmaterials.cpp

src/mat/4C_mat_micromaterial.hpp

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp

isteinbrecher

Thanks @m-frey for the changes and adding the test case, this for sure makes your implementation more future proof! I left some comments and some questions.

src/core/io/src/4C_io_discretization_visualization_writer_mesh.hpp

src/mat/4C_mat_micromaterial.hpp

src/stru_multi/4C_stru_multi_microstatic.hpp

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.hpp

isteinbrecher · 2024-12-16T07:30:50Z

tests/input_files/ref/sohex8_multiscale_macro/xxx-micro_model_1.pvd

+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>
+    <DataSet timestep="0.00000000000000e+00" group="" part="0" file="xxx-vtk-files/micro_model_1-00000.pvtu"/>


This looks wrong to me. I think this will basically load xxx-vtk-files/micro_model_1-00000.pvtu 24 times in ParaView. Why do you need to reference the same file here multiple times?

tests/input_files/ref/sohex8_multiscale_macro/xxx-vtk-files/structure-00000-0.vtu

tests/list_of_tests.cmake

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp

georghammerl · 2024-12-16T15:25:33Z

src/mat/4C_mat_micromaterial_evaluate.cpp

@@ -242,6 +242,54 @@ void Mat::MicroMaterial::prepare_output()
    actmicromatgp->prepare_output();
  }
 }


The original method prepare_output() can be renamed to what you have introduced (prepare_runtime_output()). Additionally, add your break statement and you are done here.

georghammerl · 2024-12-16T15:27:38Z

src/mat/4C_mat_micromaterial_evaluate.cpp

+
+    if (params_->runtime_output_option_ == PAR::MicroMaterial::RuntimeOutputOption::gp1) break;
+  }
+}

 // output for all procs
 void Mat::MicroMaterial::output_step_state()


output_step_state() should be obsolete with your implementations?!

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp

src/mat/4C_mat_micromaterial.hpp

src/stru_multi/4C_stru_multi_microstatic.cpp

sebproell

A few comments on the input parameters.

sebproell · 2025-01-29T20:24:54Z

src/global_legacy_module/4C_global_legacy_module_validmaterials.cpp

@@ -1585,6 +1586,14 @@ std::shared_ptr<std::vector<std::shared_ptr<Mat::MaterialDefinition>>> Global::v
    m->add_component(
        entry<double>("INITVOL", {.description = "Initial volume of RVE", .default_value = 0.0}));

+    m->add_component(selection<int>("RUNTIMEOUTPUT_GP",


Suggested change

m->add_component(selection<int>("RUNTIMEOUTPUT_GP",

m->add_component(selection<Mat::PAR::MicroMaterial>("RUNTIMEOUTPUT_GP",

The new input mechanism allows to store the enum directly. Most cases we have in the code are not using that because this was not possible before.

sebproell · 2025-01-29T20:25:12Z

src/mat/4C_mat_micromaterial.cpp

@@ -29,6 +29,16 @@ Mat::PAR::MicroMaterial::MicroMaterial(const Core::Mat::PAR::Parameter::Data& ma
      microdisnum_(matdata.parameters.get<int>("MICRODIS_NUM")),
      initvol_(matdata.parameters.get<double>("INITVOL"))
 {
+  int option = matdata.parameters.get<int>("RUNTIMEOUTPUT_GP");


Suggested change

int option = matdata.parameters.get<int>("RUNTIMEOUTPUT_GP");

int option = matdata.parameters.get<Mat::PAR::MicroMaterial::RuntimeOutputOption>("RUNTIMEOUTPUT_GP");

sebproell · 2025-01-29T20:25:24Z

src/mat/4C_mat_micromaterial.hpp

@@ -33,6 +34,13 @@ namespace Mat
      /// standard constructor
      MicroMaterial(const Core::Mat::PAR::Parameter::Data& matdata);

+      //! action parameters recognized by ale3
+      enum RuntimeOutputOption


Suggested change

enum RuntimeOutputOption

enum class RuntimeOutputOption

sebproell · 2025-01-29T20:27:24Z

src/global_legacy_module/4C_global_legacy_module_validmaterials.cpp

+        {{"none", Mat::PAR::MicroMaterial::RuntimeOutputOption::none},
+            {"gp1", Mat::PAR::MicroMaterial::RuntimeOutputOption::gp1},
+            {"all", Mat::PAR::MicroMaterial::RuntimeOutputOption::all}},
+        {.description = "implementation type",


I think a better description is warranted here.

m-frey self-assigned this Dec 10, 2024

m-frey requested review from isteinbrecher and georghammerl December 10, 2024 12:33

m-frey force-pushed the Add-runtime-output-micromaterial branch 2 times, most recently from 843154e to 88bc4f2 Compare December 10, 2024 13:24

isteinbrecher reviewed Dec 10, 2024

View reviewed changes

sebproell reviewed Dec 10, 2024

View reviewed changes

src/inpar/4C_inpar_validmaterials.cpp Outdated Show resolved Hide resolved

src/mat/4C_mat_micromaterial.hpp Outdated Show resolved Hide resolved

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp Outdated Show resolved Hide resolved

isteinbrecher reviewed Dec 16, 2024

View reviewed changes

georghammerl reviewed Dec 16, 2024

View reviewed changes

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp Show resolved Hide resolved

georghammerl reviewed Dec 16, 2024

View reviewed changes

src/structure_new/src/model_evaluator/4C_structure_new_model_evaluator_multiscale.cpp Outdated Show resolved Hide resolved

georghammerl reviewed Dec 16, 2024

View reviewed changes

src/mat/4C_mat_micromaterial.hpp Outdated Show resolved Hide resolved

georghammerl reviewed Dec 16, 2024

View reviewed changes

src/stru_multi/4C_stru_multi_microstatic.cpp Outdated Show resolved Hide resolved

m-frey added 5 commits January 29, 2025 13:57

Add runtime output for micromaterial

2bb760d

Adress review comments

0691379

Adress review comments

2537da1

Adress review comments

a70e107

Resolve merge conflicts

36565a9

m-frey force-pushed the Add-runtime-output-micromaterial branch from 0af33f6 to 36565a9 Compare January 29, 2025 14:40

Adress review comments

0c8af17

sebproell reviewed Jan 29, 2025

View reviewed changes

Remove macro and second micro output

7d5582c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add runtime output for micromaterial #143

Add runtime output for micromaterial #143

m-frey commented Dec 10, 2024 •

edited

Loading

isteinbrecher left a comment

isteinbrecher left a comment

isteinbrecher Dec 16, 2024

georghammerl Dec 16, 2024

georghammerl Dec 16, 2024

sebproell left a comment

sebproell Jan 29, 2025

sebproell Jan 29, 2025

sebproell Jan 29, 2025

sebproell Jan 29, 2025

	m->add_component(selection<int>("RUNTIMEOUTPUT_GP",
	m->add_component(selection<Mat::PAR::MicroMaterial>("RUNTIMEOUTPUT_GP",

	int option = matdata.parameters.get<int>("RUNTIMEOUTPUT_GP");
	int option = matdata.parameters.get<Mat::PAR::MicroMaterial::RuntimeOutputOption>("RUNTIMEOUTPUT_GP");

Add runtime output for micromaterial #143

Are you sure you want to change the base?

Add runtime output for micromaterial #143

Conversation

m-frey commented Dec 10, 2024 • edited Loading

Description and Context

isteinbrecher left a comment

Choose a reason for hiding this comment

isteinbrecher left a comment

Choose a reason for hiding this comment

isteinbrecher Dec 16, 2024

Choose a reason for hiding this comment

georghammerl Dec 16, 2024

Choose a reason for hiding this comment

georghammerl Dec 16, 2024

Choose a reason for hiding this comment

sebproell left a comment

Choose a reason for hiding this comment

sebproell Jan 29, 2025

Choose a reason for hiding this comment

sebproell Jan 29, 2025

Choose a reason for hiding this comment

sebproell Jan 29, 2025

Choose a reason for hiding this comment

sebproell Jan 29, 2025

Choose a reason for hiding this comment

m-frey commented Dec 10, 2024 •

edited

Loading