Consistently use none to indicate non-set function ids #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraengelhardt
added
team: input
breaking change
|
Let's see what tests fail. I'll let you know once this is ready. |
lauraengelhardt
force-pushed
the
use-none-for-nonexistent-functions
branch
2 times, most recently
from
fa65738 to
2c4a800
Compare
lauraengelhardt
force-pushed
the
use-none-for-nonexistent-functions
branch
from
6f76526 to
5d2e2e3
Compare
lauraengelhardt
changed the title
|
This PR is ready. |
|
@lauraengelhardt Thanks! This makes things much more consistent. I just wonder how big the fallout from this change is going to be. As far as I can tell, this will break every input file. Since we had a lot of breaking changes anyway, we might as well throw this one in as well. On the other hand, we should really start versioning of the input file (#74) and allow to perform these adaptations automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
0s bynones for all input function ids (FUNCTs).function_by_id.If you now use 0, -1, or any other invalid value in the input file to indicate you do not want to supply a
FUNCT, an error is thrown byfunction_by_id.I'll supply a python script I used for the replacements if needed:
replace_0_by_none_for_FUNCTs.txt
You need to fix the extension, github doesn't allow to upload *.py files.
Related Issues and Pull Requests
--