C4-23 Fix Mirror Health #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
willronchetti
commented
Feb 12, 2020
willronchetti
commented
- Previously when purging items from ElasticSearch we would grab our 'ES Mirror' on the fly which ended up doing a very expensive AWS API request
- Instead, do this once upon ESStorage initialization since the value we care about will never change regardless of blue/green deployment schedule
netsettler
approved these changes
Feb 12, 2020
| log.info('PURGE: attempting to purge %s from mirror storage %s' % (rid, mirror_env)) | ||
| # if we could not get mirror health, bail here | ||
| if 'error' in mirror_health: | ||
| if 'error' in self.mirror_health: |
There was a problem hiding this comment.
So in this case you have a dictionary with an 'error' key in it? e.g.,
{"error": "unable to do something"}
Is that right? it'd be nice to have some kind of note saying what it was looking for.
There was a problem hiding this comment.
Yes in fact we do - this actually tripped me up the first time I put this code up. See ff_utils.get_health_page (https://github.com/4dn-dcic/utils/blob/master/dcicutils/ff_utils.py#L867)
netsettler
reviewed
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.