-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding module with multiple types #106
Merged
akshay-ap
merged 15 commits into
main
from
feature-103-allow-adding-module-with-multiple-types
Sep 27, 2023
Merged
Allow adding module with multiple types #106
akshay-ap
merged 15 commits into
main
from
feature-103-allow-adding-module-with-multiple-types
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/remove-isafe-from-function-parameters
Pull Request Test Coverage Report for Build 6316718378
💛 - Coveralls |
da09d69
to
2447eef
Compare
mmv08
reviewed
Sep 20, 2023
758e938
to
2f4efc7
Compare
mmv08
approved these changes
Sep 21, 2023
Base automatically changed from
feat/remove-isafe-from-function-parameters
to
main
September 21, 2023 14:01
f04a838
to
2e70453
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Changes in PR:
moduleTypes
information from Registry. Each enabled bit in theuint8
indicates a module type.Updated function signature:
Each module type is a power of 2.
_addModule(address,uint8)
as internal function to avoid duplicate logic inTestSafeProtocolRegistryUnrestricted
Needs update in Protocol specs