-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discarded Loading Without Input and Added an Alert for Missing Data #143
base: main
Are you sure you want to change the base?
Conversation
Hi Sir's @Roaster05 @Aditya062003 , Awaiting your reviews and let me know if further improvement needed . |
Hey, pls mimic these changes in the extension too |
for sure sir! thank you. |
Hi Sir @Aditya062003 , I've implemented the required changes in the extension as well. Before :![]() After:![]() Please check it out. Thanks! |
@Aditya062003 sir I've done the necessary changes in extension as well as you mentioned. please check it out. thanks! |
Great! Could you just revert the changes for |
sure sir, i'm updating it. |
Hey @Aditya062003 sir, I've reverted the changes for package-lock.json, please check it out. Thanks! |
This pull request addresses the issue #142 .
Changes Implemented:
Input Validation:
-Added a check to ensure at least one input (text, file, or URL) is provided before proceeding.
Alert Message:
-Displays a concise and professional alert: "Please provide input (text, file, or URL) to generate your quiz."
Prevent Loading:
-Blocked the loading spinner from displaying unless the input validation passes.
Code Refactor:
-Updated the handleSaveToLocalStorage function to include validation logic for input fields.
Benefits:
-Improved User Experience: Guides the user to provide input, reducing confusion.
-Backend Optimization: Prevents empty requests, saving server resources.
-Error Prevention: Ensures meaningful data is sent to the backend.
-Professional Feedback: Aligns application behavior with standard UI/UX practices.
Testing:
Manual tests conducted to verify:
Before changes:
After changes:
Fixes #142