Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add gatefilter tests #1701

Merged
merged 4 commits into from
Dec 5, 2024
Merged

ENH: Add gatefilter tests #1701

merged 4 commits into from
Dec 5, 2024

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Dec 5, 2024 •
edited
Loading

Add tests for the lp phase code with gatefilter

  • Tests added
  • Documentation reflects changes

@mgrover1 mgrover1 requested a review from zssherman as a code owner December 5, 2024 19:59
@mgrover1 mgrover1 changed the title Add gatefilter tests ENH: Add gatefilter tests Dec 5, 2024
zssherman
zssherman approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge

@mgrover1 mgrover1 merged commit e4d22c0 into ARM-DOE:main Dec 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrover1 @zssherman