[Silicon Labs] Update board IDs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated board IDs for Silicon Labs targets.
Because of the limitation in the mbed website. See PR #4059 in ARMmbed/mbed-os.
bridadan
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
IDs look ok. Looks like the platforms haven't been renamed in the mbed site yet though. Not sure what the order of that is, but I suspect that we need to do it in the tools first. @maclobdell or @screamerbg any input here?
|
And just for reference, here is the PR in mbed OS that renames the boards: ARMmbed/mbed-os#4059 |
|
We are aligned with Steven |
|
@bridadan These targets aren't public on the website yet, which is why we can get away with renaming them :) |
|
@bridadan ARMmbed/mbed-os#4059 got merged, so this one should probably merge as well? |
|
@stevew817 Fine with me, but I don't have merge powers 😄 That's up to @mazimkhan or @adbridge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated board IDs for Silicon Labs targets.