Workaround for ARMC6 Windows 7 assembler issue #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lrusinowicz, thank you for your changes. |
theotherjimmy
suggested changes
Mar 21, 2019
|
@lrusinowicz I moved your Description header above the description. |
lrusinowicz
force-pushed
the
armc6_assembler_win7_workaround
branch
from
689b07e to
da090fa
Compare
I've done this while also changing temporary file extension to just |
theotherjimmy
approved these changes
Mar 21, 2019
theotherjimmy
suggested changes
Mar 21, 2019
On Windows 7 using --preproc option in ARMC6 assembler doesn't work when -MD option is also specified. Compiler creates incorrect filename for dependency file and compilation files. To workaround this issue, this change returns to using a temporary file and separately calling preprocessor and assembler (as in a case of ARMC5).
lrusinowicz
force-pushed
the
armc6_assembler_win7_workaround
branch
from
da090fa to
8d8cf1a
Compare
theotherjimmy
approved these changes
Mar 22, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
approved these changes
Mar 26, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 26, 2019
…7_workaround Workaround for ARMC6 Windows 7 assembler issue
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows 7 using --preproc option in ARMC6 assembler doesn't work when -MD option is also specified. Compiler creates incorrect filename for dependency file and compilation files.
To workaround this issue, this change returns to using a temporary file and separately calling preprocessor and assembler (as in a case of ARMC5).
I have done only a limited testing, because I have only access to ARMC6 compiler on a Windows 7 machine.
Pull request type
Reviewers
@theotherjimmy
Release Notes