-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New exporter build tests #2754
New exporter build tests #2754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like most of the changes, but I don't like creating objects that attach no extra meaning to the data they hold.
self.mcu = mcu | ||
self.name = name | ||
self.id = test_num | ||
self.src = src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is just a named tuple or something similar, do we need it?
tests.append(TestCase(ide, mcu, TESTS[test]["id"], | ||
test_num=test)) | ||
for test in v5_tests: | ||
tests.append(TestCase(ide, mcu, test[0], src=[test[1],ROOT])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it's use case, just make it a dict or a named tuple.
26fb8a3
to
5cba51a
Compare
/morph export-build |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
So awesome enough, uVision was all passing (besides the skipped targets)! IAR has quite a bit of failures, this is due to the IAR issues listed here, right @sarahmarshy ? |
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Running now with the /morph export-build |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uVision is all passing for --release 2
. There's a lot of skipped targets but that's probably ok @sarahmarshy ? When is a target skipped?
IAR had failures, in fact it had more failures, but that's only because we weren't testing those platforms before 😄
If @sarahmarshy and @theotherjimmy are happy with this after looking at the results then so am I!
Target is skipped if it doesn't have a progen definition (https://github.com/project-generator/project_generator_definitions) for that particular IDE |
@sg- Looks like we're good to merge here. |
@sarahmarshy looks like it needs a rebase and conflict resolved. |
*Changes* - Parallel export - mbed-os tests added - specified release version (default to 5) - default tests AND targets dependent on specified release version
f055e45
to
16913b9
Compare
@sg- rebased. |
@bridadan the test for uvision5 will be uvision now, with this rebased on Marcelo's changes. |
@sarahmarshy Thanks for the heads up, I made the change and I'll go ahead and kick off one more test. /morph export-build |
@sarahmarshy I'm looking at the interim results and IAR looks to be all failing at the moment with these kind of errors:
Pretty sure this was introduced with PR #2745 (which coincidentally, we didn't run the export-build test 😞 ) Any idea why this works in the mbed build system but not in IAR? |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
@sarahmarshy Also had to kill the exporter test for uvision, looks like it started to hang when the mbed build system started up for another job. The IAR results should still be useful to you |
From the command line output of build system I see |
@bridadan will be a separate PR though. |
@sarahmarshy makes sense to me! |
Fix in #2787 |
Description
Export-build test now exports projects in parallel. It is also capable of testing the export of mbed-os tests. They can be found in the mbed-os/TESTS. The targets and tests are by default those from the latest release, though you can specify previous releases.
Status
READY
Migrations
Running export-build tests
You will need to add 2 environment variables:
Please add UV4.exe and IarBuild.exe as variables UV4 and IARBUILD, respectively.
On Windows:
UV4 is usually found in:
C:\Keil_v5\UV4\UV4.exe
IarBuild is usually found in:
C:\Program Files (x86)\IAR Systems\Embedded Workbench 7.x\common\bin\IarBuild.exe
YES
Related PRs
List related PRs against other branches:
cherry picked changes from #2708
Changes
@bridadan