Removed --no_static_destruction from IAR IDE flags #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph export-build |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
|
Sorry! Got this PR number mixed up with #2708 when cancelling jobs. /morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes #2745 IAR from the IAR IDE. The DEFAULT_FLAGS also go to the IAR IDE when exporting. This is a problem, as IAR only allows the c and c++ flags to be distinct through configuration window checkboxes. In other words (and pictures), they share a common list of flags except the following options:
Frustratingly, these can only be set here, and are disallowed from the common list (which looks just as command line flag strings would look). I assume they just append those flags given the selections seen here, as setting them in that list produces duplicated flag errors (even if the boxes are unchecked!).
For now, this optimization will be left off of the IAR IDE options, as it requires some XML shenanigans. I'd like to add that functionality to #2708. As it is, it would require a progen PR.
Status
READY
Migrations
NO
Steps to test or reproduce
Try to export and build IAR on master and with this branch.
@bridadan @sg-