User trim values for NCS36510

[radhika-raghavendran]

Adding user trim programming for NCS36510. Attached is the test result.
GCC_ARM_TestResults-28-10-2016.txt

[0xc0170]

I wonder if this should be part of the targets.json and add this config there or placed here as it is

cc @sg- @bogdanm @c1728p9

[sg-]

@radhika-raghavendran can you move the config into targets.json? https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1838

[radhika-raghavendran]

@sg- Would it be better to retain ncs36510_user_trim.json as is and placed in the same folder as targets.json?
Can you give some information about how "config" parameter is used in targets.json file? Looks like we can fit in the user trim values using the config parameter. We need to modify our post build script in order to make this change. The FIB as well as the user trim values are a part of the generated binary which is programmed on NCS3510 board. Any suggestions?

[sg-]

The config can be placed in targets.json just like https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1839 This will reduce hidden config files

[radhika-raghavendran]

I had a look at https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1839.
Can I use the value in the tag "hf_clock_src" in the above example in a python script file?
I am still unclear about how this config can be used while generating binary. Can you give me any existing example?

[0xc0170]

Can I use the value in the tag "hf_clock_src" in the above example in a python script file?

Yes, look at Config class, that would return what you need (provides API to get targets data). should be get_target_config_data()

[radhika-raghavendran]

@0xc0170 Using this API does not give me the value of the tag.
There is no API to get the 'value' of the tag parameter directly. By using this API I get values like this:

Data params {'target.mac-addr-high': tools.config.ConfigParameter object at 0x000000000369C4A8, 'target.txtune-trim': <tools.config.ConfigParameter object at 0x000000000369C748, 'target.32MHz-clk-trim': <tools.config.ConfigParameter object at 0x000000000369C5F8, 'target.mac-addr-low': <tools.config.ConfigParameter object at 0x000000000369C438, 'target.32KHz-clk-trim': <tools.config.ConfigParameter object at 0x000000000369C550, 'target.rssi-trim': <tools.config.ConfigParameter object at 0x000000000369C6A0}

Here is the config params:
"config": {
"mac-addr-low": {
"help": "Lower 32 bits of the MAC extended address",
"value": "0x12345678"
},
"mac-addr-high": {
"help": "Higher 32 bits of the MAC extended address",
"value": "0xACDE4800"
},
"32KHz-clk-trim": {
"help": "32KHz clock trim",
"value": "0x3A"
},
"32MHz-clk-trim": {
"help": "32MHz clock trim",
"value": "0x16"
},
"rssi-trim": {
"help": "RSSI trim",
"value": "0x3D"
},
"txtune-trim": {
"help": "TX tune trim",
"value": "0x12"
}

Any sample usage will be very helpful. Thanks

[0xc0170]

@bogdanm Could you please look at the comment above?

[bogdanm]

@radhika-raghavendran, once you have a ConfigParameter instance, you cat access its value field to get the value of the config parameter. In the future, we'll probably want to add a get_value method to ConfigParameter. Cc @theotherjimmy

[radhika-raghavendran]

@0xc0170 I have made the necessary changes to remove usage of a separate json file in targets and added configuration data for NCS36510 in targets.json file. You can review and let me know if there is a better way to implement the same. A get_value method with the name of the tag for ConfigParameter class would be very useful.

[maclobdell]

Hi @radhika-raghavendran,
Per our discussion on the phone I think setting the default MAC address to 0xFFFF... and adding description in the help that if all FFs then the value is ignored and factory-trim MAC value is used. That way users can take advantage of the factory MAC by default, and change it later if they want to.

Thanks!

[radhika-raghavendran]

@maclobdell : Modifications made for MAC address and other trim default values. Comments added in json file. Thanks

[radhika-raghavendran]

Attached are the latest test results.
GCC_ARM_TestResults-09-11-2016.txt

[0xc0170]

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1031

All builds and test passed!