[Exporter tests] Export only #3205
Conversation
sarahmarshy
changed the title
…ave build functions
sarahmarshy
force-pushed
the
export-build-only-export
branch
from
187bb0a to
76554fa
Compare
| @@ -19,7 +19,8 @@ | |||
| from tools.export import EXPORTERS | |||
|
|
|||
| SUPPORTED_TOOLCHAINS = ["ARM", "IAR", "GCC_ARM"] | |||
| SUPPORTED_IDES = ["iar", "uvision", "make_gcc_arm", "make_iar", "make_armc5"] | |||
| SUPPORTED_IDES = [exp for exp in EXPORTERS.keys() if exp != "cmsis" and exp != "zip"] | |||
There was a problem hiding this comment.
Is there a reason why "cmsis" and "zip" exporters aren't being listed in the supported_ides? Do they lack build steps?
There was a problem hiding this comment.
Can we introspect the class then to see if there's a build function and filter based on that?
There was a problem hiding this comment.
Further, their generate functions are just bizarre. Zip returns True and CMSIS exports a useless .cpdsc (this one is ust experimental right now).
If we did that, then those others that don't have a build (kds, etc) wouldn't be allowed to do the just exporting part (which is the point of this pr).
There was a problem hiding this comment.
I see. So CMSIS is being excluded now because its experimental, and it sounds like Zip may need to be updated?
There was a problem hiding this comment.
Zip just does weird stuff for the online IDE, I think.
There was a problem hiding this comment.
Ok, it sounds like these two exporters truly are just strange. In that case the way it's implemented now isn't an issue. 👍
| Args: | ||
| config - the json object imported from the file. | ||
| ides - List of IDES to export to | ||
| """ |
|
No CI is hitting this functionality in this script yet, so should be OK to merge. |
Description
Exporter build tests for exporters that have no build function (simplicity, kds, etc) will be tested for their ability to export with no tracebacks.
(Additionally added prettier printing organization for results).
Status
READY
Todos