Enabled example export building for more examples #3331

theotherjimmy · 2016-11-28T21:04:06Z

Description

Turns on export building for many examples that we should be building, and filters exporters with the toolchain specified in the example JSON file.

TODO

CI!
Check that CI ran the additional tests that were turned on.

theotherjimmy · 2016-11-28T21:04:17Z

/morph export-build

c1728p9 · 2016-11-28T21:07:49Z

Don't merge this patch

geky · 2016-11-28T21:08:23Z

@c1728p9 Should we merge this patch?

theotherjimmy · 2016-11-28T21:08:50Z

Please Don't. @geky happy to clarify for you.

mbed-bot · 2016-11-28T21:26:34Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 26

Exporter Build failed!

theotherjimmy · 2016-11-28T21:27:46Z

All failures are that it tried to export and compile uvisior with not gcc

theotherjimmy · 2016-11-28T21:27:59Z

complete success!

theotherjimmy · 2016-11-28T21:34:07Z

/morph export-build

theotherjimmy · 2016-11-28T21:51:49Z

/morph export-build

mbed-bot · 2016-11-28T21:53:01Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 27

Exporter Build failed!

mbed-bot · 2016-11-28T22:19:04Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 28

Exporter Build failed!

theotherjimmy · 2016-11-28T22:53:12Z

/morph export-build

mbed-bot · 2016-11-28T22:59:34Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 29

Exporter Build failed!

theotherjimmy · 2016-11-28T23:00:28Z

/morph export-build

mbed-bot · 2016-11-28T23:28:05Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 30

All exports and builds passed!

theotherjimmy · 2016-11-28T23:28:20Z

hahaha!

theotherjimmy · 2016-11-28T23:53:52Z

/morph export-build

theotherjimmy · 2016-11-29T00:01:11Z

/morph export-build

mbed-bot · 2016-11-29T00:01:40Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 31

Exporter Build failed!

mbed-bot · 2016-11-29T00:42:30Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 32

Exporter Build failed!

0xc0170 · 2016-11-29T11:31:19Z

@theotherjimmy Is it that unstable? the latest build is quite red.

0xc0170 · 2016-11-29T14:28:15Z

Rerunning as it might be the sam eproblem as other PR (jenkins failure).

/morph export-build

mbed-bot · 2016-11-29T15:31:28Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 33

Exporter Build failed!

mbed-bot · 2016-12-01T23:07:30Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 41

Exporter Build failed!

theotherjimmy · 2016-12-01T23:09:19Z

/morph export-build

mbed-bot · 2016-12-01T23:40:00Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 42

Exporter Build failed!

theotherjimmy · 2016-12-02T21:52:57Z

/morph export-build

mbed-bot · 2016-12-02T22:26:47Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 44

All exports and builds passed!

theotherjimmy · 2016-12-02T22:50:02Z

should resolve #2679

0xc0170 · 2016-12-05T13:46:23Z

tools/test/examples/examples.json

-      "features" : ["IPV6"],
-      "targets" : [],
+      "features" : [],
+        "targets" : ["DISCO_F469NI", "DISCO_F746NG", "K64F", "K66F",


misaligned targets?

My editor seems to think that the entire file is misaligned. I'll fix this instance shortly

There you go.

0xc0170 · 2016-12-05T13:47:03Z

LGTM (just that one nit)

0xc0170 · 2016-12-07T11:58:03Z

/morph export-build

mbed-bot · 2016-12-07T16:05:40Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 45

All exports and builds passed!

bridadan · 2016-12-08T17:34:25Z

Nice work @theotherjimmy.

We should run the other mbed os tests on this too since it affects the compiles done through mbed build system as well.

/morph test

mbed-bot · 2016-12-08T21:14:33Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

Output

mbed Build Number: 1230

All builds and test passed!

bridadan · 2016-12-09T15:33:39Z

Way to wrestle with the CI and get this in, should make the release process a lot better 👍

theotherjimmy added the do not merge label Nov 28, 2016

geky added do not merge and removed do not merge labels Nov 28, 2016

theotherjimmy force-pushed the enable-exporters-examples branch from 55c5075 to 03dc17b Compare November 28, 2016 23:31

theotherjimmy added needs: CI and removed do not merge labels Nov 28, 2016

theotherjimmy force-pushed the enable-exporters-examples branch from 03dc17b to 89a0544 Compare November 29, 2016 00:00

0xc0170 approved these changes Dec 5, 2016

View reviewed changes

0xc0170 reviewed Dec 5, 2016

View reviewed changes

0xc0170 removed the needs: CI label Dec 5, 2016

0xc0170 added the needs: work label Dec 5, 2016

Enabled example exporting Filter ides by toolchains

5698085

theotherjimmy force-pushed the enable-exporters-examples branch from 095302b to 5698085 Compare December 5, 2016 19:44

0xc0170 removed the needs: work label Dec 7, 2016

0xc0170 added the needs: CI label Dec 7, 2016

0xc0170 added ready for merge and removed needs: CI labels Dec 8, 2016

bridadan added needs: CI and removed ready for merge labels Dec 8, 2016

bridadan added ready for merge and removed needs: CI labels Dec 8, 2016

0xc0170 added release-version: 5.3.1 and removed ready for merge labels Dec 9, 2016

0xc0170 merged commit 9da9166 into ARMmbed:master Dec 9, 2016

bridadan mentioned this pull request Dec 13, 2016

Examples build test doesn't build examples that require feature IPV6 #2679

Closed

Enabled example export building for more examples #3331

Enabled example export building for more examples #3331

Conversation

theotherjimmy commented Nov 28, 2016 • edited Loading

Description

TODO

theotherjimmy commented Nov 28, 2016

c1728p9 commented Nov 28, 2016

geky commented Nov 28, 2016

theotherjimmy commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

Output

theotherjimmy commented Nov 28, 2016

theotherjimmy commented Nov 28, 2016

theotherjimmy commented Nov 28, 2016

theotherjimmy commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

Output

mbed-bot commented Nov 28, 2016

Output

theotherjimmy commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

Output

theotherjimmy commented Nov 28, 2016

mbed-bot commented Nov 28, 2016

Output

theotherjimmy commented Nov 28, 2016

theotherjimmy commented Nov 28, 2016

theotherjimmy commented Nov 29, 2016

mbed-bot commented Nov 29, 2016

Output

mbed-bot commented Nov 29, 2016

Output

0xc0170 commented Nov 29, 2016

0xc0170 commented Nov 29, 2016

mbed-bot commented Nov 29, 2016

Output

mbed-bot commented Dec 1, 2016

Output

theotherjimmy commented Dec 1, 2016

mbed-bot commented Dec 1, 2016

Output

theotherjimmy commented Dec 2, 2016

mbed-bot commented Dec 2, 2016

Output

theotherjimmy commented Dec 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Dec 5, 2016

0xc0170 commented Dec 7, 2016

mbed-bot commented Dec 7, 2016

Output

bridadan commented Dec 8, 2016

mbed-bot commented Dec 8, 2016

Output

bridadan commented Dec 9, 2016

theotherjimmy commented Nov 28, 2016 •

edited

Loading