IAR export will not fail in the absence of a CMSIS pack #3355
Conversation
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 43 All exports and builds passed! |
|
|
||
| try: | ||
| debugger = DeviceCMSIS(self.target).debug.replace('-','').upper() | ||
| except: |
There was a problem hiding this comment.
do we want to catch any exception or should we a specific that deviceCMSIS documents it can throw?
There was a problem hiding this comment.
Perhaps. I'd kind of rather that this bit of code never fails. You should always get a debug interface, at least CMSIS-DAP. But I could catch the existing thrown exception, TargetNotSupported.
https://github.com/ARMmbed/mbed-os/blob/master/tools/export/cmsis/__init__.py#L38
There was a problem hiding this comment.
Even if a user presses C-c?
|
/morph export-build |
|
@theotherjimmy changed the exception catching |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 46 All exports and builds passed! |
|
Cool. LGTM |
Currently, IAR requires that device has a CMSIS pack to find the debug interface. With that assumption, if a debug interface cannot be found, it defaults to CMSIS-DAP. This change will mean that the default CMSIS-DAP is also used when there is not CMSIS pack at all.
Fixes #3286
@theotherjimmy