Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in tools #3998

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Conversation

theotherjimmy
Copy link
Contributor

Testing

  • hammer it with everything: /morph nightly

@theotherjimmy
Copy link
Contributor Author

@bridadan Let's hit this with all we have.

@adbridge
Copy link
Contributor

adbridge commented Mar 23, 2017

@theotherjimmy Please give the PR a meaningful title as this goes into the release note.

Remove pile of dead code

is ambiguous to say the least. Also please add how you tested this and the results.

@theotherjimmy
Copy link
Contributor Author

@adbridge Does the commit message go into the release notes or the PR title? I thought it was the commit message.

@theotherjimmy theotherjimmy changed the title Remove pile of dead code Remove dead code in tools Mar 23, 2017
@theotherjimmy
Copy link
Contributor Author

@adbridge Changed title and commit message

@theotherjimmy
Copy link
Contributor Author

Travis stalled, so I restarted it.

@bridadan
Copy link
Contributor

Gonna just use normal test job since nightly just runs more hardware tests, which I wouldn't expect this to affect.

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1729

All builds and test passed!

@theotherjimmy
Copy link
Contributor Author

Looks like the Oulu CI is reporting an error, but I'm having trouble reading it. @tommikas could you help me out with this?

@tommikas
Copy link
Contributor

tommikas commented Mar 24, 2017

@theotherjimmy The wlan tests are failing. I'm not quite sure why exactly, and the people who could help debug the issue haven't been at the office today. In any case, I very much doubt it's related to this PR.

@adbridge @0xc0170 @bridadan FYI: I've temporarily disabled the wlan tests since I can't do anything about this until Monday. Hopefully that'll allow unrelated PRs to start passing.

@theotherjimmy
Copy link
Contributor Author

@tommikas would a restart of the Oulu CI on this PR be appropriate?

@bridadan
Copy link
Contributor

Pretty sure those failures were caused by a network issue with the developer site, I've restarted the job.

@sg- sg- merged commit c958eb4 into ARMmbed:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants