-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code in tools #3998
Conversation
@bridadan Let's hit this with all we have. |
@theotherjimmy Please give the PR a meaningful title as this goes into the release note.
is ambiguous to say the least. Also please add how you tested this and the results. |
@adbridge Does the commit message go into the release notes or the PR title? I thought it was the commit message. |
82c4ae8
to
75ec7b7
Compare
@adbridge Changed title and commit message |
Travis stalled, so I restarted it. |
Gonna just use normal test job since nightly just runs more hardware tests, which I wouldn't expect this to affect. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Looks like the Oulu CI is reporting an error, but I'm having trouble reading it. @tommikas could you help me out with this? |
@theotherjimmy The wlan tests are failing. I'm not quite sure why exactly, and the people who could help debug the issue haven't been at the office today. In any case, I very much doubt it's related to this PR. @adbridge @0xc0170 @bridadan FYI: I've temporarily disabled the wlan tests since I can't do anything about this until Monday. Hopefully that'll allow unrelated PRs to start passing. |
@tommikas would a restart of the Oulu CI on this PR be appropriate? |
Pretty sure those failures were caused by a network issue with the developer site, I've restarted the job. |
Testing