Include mbed_debug.h in mbed.h

[sarahmarshy]

Description

Allows access to mbed debug printing when including mbed.h

Steps to test or reproduce

Currently, you must include mbed_debug.h in addition to mbed.h if you want to use the debug print function.

[geky]

+1

[0xc0170]

/morph test

[0xc0170]

@tommikas I restarted Jenkins again, can you have a look at the failure? I don't find it related to this changeset

[bridadan]

/morph test

[tommikas]

@0xc0170 It sort of is related. This inclusion causes a conflict between two functions called debug.

Compile [ 52.5%]: LoWPANNDInterface.cpp
[Error] ns_trace.h@81,25: conflicting declaration of C function 'void debug(const char*)'
[ERROR] In file included from ./mbed-os/features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/source/LoWPANNDInterface.cpp:7:0:
./mbed-os/features/FEATURE_COMMON_PAL/nanostack-libservice/mbed-client-libservice/ns_trace.h:81:25: error: conflicting declaration of C function 'void debug(const char*)'
 void debug(const char *s);                                                          //!< obsolete function
                         ^
In file included from ./mbed-os/mbed.h:66:0,
                 from ./mbed-os/features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/MeshInterfaceNanostack.h:19,
                 from ./mbed-os/features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/LoWPANNDInterface.h:20,
                 from ./mbed-os/features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/source/LoWPANNDInterface.cpp:1:
./mbed-os/platform/mbed_debug.h:35:20: note: previous declaration 'void debug(const char*, ...)'
 static inline void debug(const char *format, ...) {

https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_debug.h#L60
https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_COMMON_PAL/nanostack-libservice/mbed-client-libservice/ns_trace.h#L81

The version in nanostack-libservice is a legacy function that was left for backwards compatibility when migrating to using mbed-trace. I think it could safely be cleaned out at this point.

@SeppoTakalo, @kjbracey-arm, what do you think?

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 29

All builds and test passed!

[0xc0170]

@SeppoTakalo, @kjbracey-arm, what do you think?

Any ideas?

[SeppoTakalo]

@0xc0170 @tommikas Yes, the debug() function can, and should, be removed from ns_trace library.

I'll propose that ns_trace would be changed first and once its changes are merged into master repo, the change would be merged in mbed-os also. Then this would pass the build.

[0xc0170]

I'll propose that ns_trace would be changed first and once its changes are merged into master repo, the change would be merged in mbed-os also. Then this would pass the build.

Ok, who can take the action for this one? I'll label this as "needs work"

[tommikas]

I actually seem to have an old PR into libservice to clean out some ns_trace stuff. I think the PR got left hanging due to summer holidays and organizational changes. I'll update that. Once that is in @SeppoTakalo or someone can submit the updated libservice here.

[theotherjimmy]

bump @SeppoTakalo

[tommikas]

@theotherjimmy Just updated the aforementioned PR.

[theotherjimmy]

@SeppoTakalo @tommikas What's the status of this?

[theotherjimmy]

@sarahmarshy What's the status of this one?

[tommikas]

@theotherjimmy #4235 should unblock this.

[tommikas]

#4235 has been merged. CI is passing now.