Fix timeout units in events timing test #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A units mistake led to passing 20000 seconds instead of 20000 milliseconds to greentea. The would cause the test to spin for 6 hours if it got stuck anywhere.
|
/morph test |
geky
approved these changes
May 12, 2017
Ouch |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
bulislaw
approved these changes
May 15, 2017
pan-
approved these changes
May 15, 2017
0xc0170
added
ready for merge
release-version: 5.4.6
and removed
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A units mistake led to passing 20000 seconds instead of 20000 milliseconds to greentea. The would cause the test to spin for 6 hours if it got stuck anywhere.
Taken from commit 8b5dee8 in the CMSIS_5 branch.