Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed-coap fixes #4455

Merged
merged 2 commits into from
Jun 6, 2017
Merged

mbed-coap fixes #4455

merged 2 commits into from
Jun 6, 2017

Conversation

anttiylitokola
Copy link
Contributor

@anttiylitokola anttiylitokola commented Jun 6, 2017

Description

This commit includes:

  • Add support for sending response to duplicate messages
  • Add randomness for retransmission time
  • Fix usage sn coap blockwise max time data stored
  • CoAP parser option handler does not seem to handle "Option Length" completely according to spec
  • Handle '0' value if duplication buffer size is set through the sn_coap_protocol_set_duplicate_buffer_size()

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

Detailed Changelog available here PelionIoT/mbed-coap@v4.0.4...v4.0.6

This commit includes:
 * Add support for sending response to duplicate messages
 * Add randomness for retransmission time
 * Fix usage sn coap blockwise max time data stored
 * CoAP parser option handler does not seem to handle "Option Length" completely according to spec
 * Handle '0' value if duplication buffer size is set through the sn_coap_protocol_set_duplicate_buffer_size()
@anttiylitokola
Copy link
Contributor Author

@adbridge @0xc0170 @sg- Please review and take this in mbed-os 5.4.7 and 5.5.0.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2017

@adbridge @0xc0170 @sg- Please review and take this in mbed-os 5.4.7 and 5.5.0.

Is it that critical for 5.4.7 ? That one was generated yesterday and under test today

@anttiylitokola
Copy link
Contributor Author

Would be nice to get in also to 5.4.7 since we would like to use this release in mbed cloud 1.2 beta release.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2017

I restarted failed jenkins CI (timeout), please have a look once the new build finishes

/morph test

@anttiylitokola
Copy link
Contributor Author

There is one regression which needs to be fixed before this can proceed. I'll fix it shortly so you can take this further.

 * Cause regression in cloud registration
@anttiylitokola
Copy link
Contributor Author

Commit d399395 fix the regression.

@adbridge
Copy link
Contributor

adbridge commented Jun 6, 2017

@anttiylitokola Thanks for the update, I will kick off the CI

@adbridge
Copy link
Contributor

adbridge commented Jun 6, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Jun 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 459

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants