Fix the issue #4357: NRF52 doesn't support simultaneous use of I2C and SPI. #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
suggested changes
Jun 27, 2017
| @@ -277,9 +277,11 @@ void spi_init(spi_t *obj, | |||
| } | |||
| } | |||
|
|
|||
| for (i = 0; i < SPI_COUNT; ++i) { | |||
| for (i = SPI_COUNT - 1; i < SPI_COUNT; i--) { | |||
There was a problem hiding this comment.
The loop condition should be i >= 0.
Use serial-box of Nordic nRF5 SDK to share resource between SPI and I2C. SPI is allocated from highest hw instance number resource in order to allocate as many I2C instances as possible.
nvlsianpu
force-pushed
the
bugfix/issue_4357_I2C_SPI_simultaneously
branch
from
aa8b44e to
3236336
Compare
anangl
approved these changes
Jun 27, 2017
|
@theotherjimmy travis-ci failure is not related to the changes. |
|
@nvlsianpu Yep. I restarted travis. It should not fail in the same way this time. I hope it passes. |
|
retest uvisor |
0xc0170
approved these changes
Jul 3, 2017
|
@0xc0170 what's the status? |
|
@pan- Would you run your BT testing? /morph test |
|
@theotherjimmy There is literally no point at running bluetooth tests, this PR fix an i2c and spi issue. None of those peripherals are used during BLE testing. |
|
Thanks! We'll wait for morph test then. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Support for sharing resources between SPI and TWI instancess.
This fix the issue #4357: NRF52 doesn't support simultaneous use of I2C and SPI.
Now this resources are reserved by each of hal driver using nRF5 SDK's serial-box mechanism.
Status
READY